Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Dec 10, 2024

No description provided.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 10, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 10, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 20

Inputs:

Sources:

sdk-nrf: PR head: f81641bb6a53ae25f82e63ebc1ff3669267248e4
suit-generator: PR head: f07d308f03e039bc73767c145f4cff4a70e74442

more details

sdk-nrf:

PR head: f81641bb6a53ae25f82e63ebc1ff3669267248e4
merge base: cac49ac985664e9357e1c30691ce1091470c528b
target head (main): a8f2725972edcde86068c20577db77b05887881d
Diff

suit-generator:

PR head: f07d308f03e039bc73767c145f4cff4a70e74442
merge base: aa3da7d6c15960b3346cdaf3587ca666c21db953
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (48)
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  │ build.py
│  │  │  ├── suit_generator
│  │  │  │  ├── cmd_image.py
│  │  │  │  ├── suit
│  │  │  │  │  │ manifest.py
subsys
│  ├── suit
│  │  ├── manifest_variables
│  │  │  │ Kconfig
│  │  ├── platform
│  │  │  ├── CMakeLists.txt
│  │  │  ├── app
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── src
│  │  │  │  │  ├── suit_plat_check_content.c
│  │  │  │  │  ├── suit_plat_check_content_app_specific.c
│  │  │  │  │  ├── suit_plat_copy.c
│  │  │  │  │  ├── suit_plat_copy_app_specific.c
│  │  │  │  │  ├── suit_plat_write.c
│  │  │  │  │  │ suit_plat_write_app_specific.c
│  │  │  ├── include
│  │  │  │  ├── suit_plat_check_content_domain_specific.h
│  │  │  │  ├── suit_plat_copy_domain_specific.h
│  │  │  │  ├── suit_plat_write_domain_specific.h
│  │  │  │  │ suit_platform_internal.h
│  │  │  ├── sdfw
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── src
│  │  │  │  │  ├── suit_plat_authenticate.c
│  │  │  │  │  ├── suit_plat_check_content_sdfw_specific.c
│  │  │  │  │  ├── suit_plat_copy_sdfw_specific.c
│  │  │  │  │  │ suit_plat_write_sdfw_specific.c
│  │  │  ├── src
│  │  │  │  ├── suit_plat_check_content.c
│  │  │  │  ├── suit_plat_copy.c
│  │  │  │  │ suit_plat_write.c
│  │  ├── utils
│  │  │  ├── include
│  │  │  │  │ suit_plat_decode_util.h
│  │  │  ├── src
│  │  │  │  │ suit_plat_decode_util.c
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── check_content
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  ├── native_sim.conf
│  │  │  │  │  ├── native_sim.overlay
│  │  │  │  │  ├── native_sim_64.conf
│  │  │  │  │  ├── native_sim_64.overlay
│  │  │  │  │  │ nrf52840dk_nrf52840.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── copy
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  ├── native_sim.overlay
│  │  │  │  │  ├── native_sim_64.overlay
│  │  │  │  │  │ nrf52840dk_nrf52840.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── write
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  ├── native_sim.overlay
│  │  │  │  │  ├── native_sim_64.overlay
│  │  │  │  │  │ nrf52840dk_nrf52840.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
west.yml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
    • ◻️ test-fw-nrfconnect-chip
    • ◻️ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 10, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@aa3da7d nrfconnect/suit-generator@f07d308 (ncs) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch 5 times, most recently from 4c38772 to 7210d22 Compare December 11, 2024 15:40
@tomchy tomchy marked this pull request as ready for review December 12, 2024 09:15
@tomchy tomchy requested a review from a team as a code owner December 12, 2024 09:15
@tomchy tomchy requested a review from a team December 12, 2024 09:15
@tomchy tomchy requested a review from a team as a code owner December 12, 2024 09:15
@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from 7210d22 to c8a1d3d Compare December 12, 2024 09:15
Copy link
Contributor

@ahasztag ahasztag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On bug found, except for that a couple of suggestions

@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from c8a1d3d to c01a6d2 Compare December 12, 2024 13:23
@tomchy tomchy requested a review from ahasztag December 12, 2024 13:23
@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from c01a6d2 to 4780aa5 Compare December 16, 2024 10:59
@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from 4780aa5 to 202c24a Compare December 16, 2024 14:25
tomchy added 8 commits January 7, 2025 09:29
Describe dependencies between manifest variable implementation and other
SUIT subsystem components.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add API that checks if manifest with given component ID is entitled to
change the value of manifest variable.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add support for writing content into MFST_VAR components.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add tests that verify if writing content into manifest variables is
possible.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a possibility to check content of manifest variables from both
application and SDFW platform code.

Ref: NCSDK-20807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add test cases for that verify if it is possible to check content of
manifest variables.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add support for copying MFST_VAR content between manifes variables.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add tests that verify if copying content between manifest variables is
possible.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from 202c24a to 79d7c70 Compare January 7, 2025 08:30
Update suit-generator revision.

Ref: NCSDK-30807

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch from 79d7c70 to f81641b Compare January 7, 2025 10:18
@NordicBuilder NordicBuilder removed the DNM label Jan 7, 2025
@tomchy tomchy merged commit 741cb7a into nrfconnect:main Jan 7, 2025
13 of 14 checks passed
@tomchy tomchy deleted the feature/suit/NCSDK-30807_Add_support_for_mfst_var branch June 25, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-suit-generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants