Skip to content

nrf_security: Rename a Kconfig option and the cmake target #22327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented May 14, 2025

Renames the oberon_psa_core cmake target to psa_core which is more generic.
Renames the PSA_USE_CRACEN_ASYMMETRIC_DRIVER to PSA_USE_CRACEN_ASYMMETRIC_ENCRYPTION_DRIVER to be more descriptive.

@Vge0rge Vge0rge requested review from a team as code owners May 14, 2025 14:47
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 14, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 14, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: bb8f1f98e26c89b665b0191b799ccc29e12503cd
find-my: PR head: 783d2f16c7d7c0f5220f14eeb269b576f493e2f8

more details

sdk-nrf:

PR head: bb8f1f98e26c89b665b0191b799ccc29e12503cd
merge base: 680aba9ccc9d21d43a4b0560123fc009cda0a3d9
target head (main): f445c275ac658dd40eaa28cb7124326522f843db
Diff

find-my:

PR head: 783d2f16c7d7c0f5220f14eeb269b576f493e2f8
merge base: 90b93338d2bbfddb47b397e4ef5bf8e5d6fe11aa
target head (main): 90b93338d2bbfddb47b397e4ef5bf8e5d6fe11aa
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (21)
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── security
│  │  │  │  ├── nrf_security
│  │  │  │  │  ├── doc
│  │  │  │  │  │  │ driver_config.rst
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  │ migration_guide_3.1.rst
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── central_hids
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  │  ├── central_uart
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  │  ├── fast_pair
│  │  │  ├── locator_tag
│  │  │  │  ├── configuration
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l05_cpuapp.conf
│  │  ├── peripheral_hids_keyboard
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  │  ├── peripheral_hids_mouse
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  │  ├── peripheral_lbs
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  │  ├── peripheral_uart
│  │  │  ├── boards
│  │  │  │  │ nrf54lm20pdk_nrf54lm20a_cpuapp.conf
│  ├── bootloader
│  │  ├── socs
│  │  │  │ nrf54l15_cpuapp.conf
subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── core
│  │  │  │  ├── lite
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── nrf_oberon
│  │  │  │  │  │ CMakeLists.txt
│  │  │  ├── drivers
│  │  │  │  ├── Kconfig
│  │  │  │  ├── cracen
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │ psa_driver.Kconfig
│  │  │  │  ├── nrf_cc3xx
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── nrf_cc3xx_platform
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── nrf_oberon
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── zephyr
│  │  │  │  │  │ CMakeLists.txt
west.yml

File list hidden for private repositories.
If you have access you can see the diff via the github link.
find-my Diff

Outputs:

Toolchain

Version: 1d2c5d0ab5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:1d2c5d0ab5_e85602c25f

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 35
  • ❌ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-tfm
    • ✅ test-sdk-find-my
    • ❌ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test_ble_nrf_config
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@Vge0rge Vge0rge added the DNM label May 15, 2025
@Vge0rge
Copy link
Contributor Author

Vge0rge commented May 15, 2025

Tagging it as do not merge because of internal reasons. This is still ready to review.

@Vge0rge Vge0rge force-pushed the nrf_security_renames branch 2 times, most recently from b2932fd to 43cb869 Compare May 15, 2025 08:57
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits.

@Vge0rge Vge0rge requested review from a team as code owners May 16, 2025 12:52
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 16, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
find-my https://github.com/nrfconnect/sdk-find-my/commit/90b93338d2bbfddb47b397e4ef5bf8e5d6fe11aa (main) https://github.com/nrfconnect/sdk-find-my/pull/314 nrfconnect/sdk-find-my#314/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Vge0rge added 3 commits May 19, 2025 10:24
Since now there is support for both Oberon PSA core
and PSA core lite rename the cmake target to a more
generic name.

Ref: NCSDK-32817

Signed-off-by: Georgios Vasilakis <[email protected]>
Rename the symbol PSA_USE_CRACEN_ASYMMETRIC_DRIVER to
PSA_USE_CRACEN_ASYMMETRIC_ENCRYPTION_DRIVER to be more
descriptive and also consistent with the CC3XX naming.

While doing this I noticed that in some cases the
option PSA_USE_CRACEN_ASYMMETRIC_DRIVER was incorrectly
used where the option PSA_USE_CRACEN_ASYMMETRIC_SIGNATURE_DRIVER
should have been used so I updated that as well.

Ref: NCSDK-32775

Signed-off-by: Georgios Vasilakis <[email protected]>
Update find-my with the new configuration for
the Cracen assymetric driver.

Signed-off-by: Georgios Vasilakis <[email protected]>
@Vge0rge Vge0rge force-pushed the nrf_security_renames branch from 834cd17 to bb8f1f9 Compare May 19, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM doc-required PR must not be merged without tech writer approval. manifest manifest-find-my
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants