cmake/sysbuild/image_signing: allow usage --rom-fixed for images target partition recognition by nvlsianpu · Pull Request #23242 · nrfconnect/sdk-nrf

nvlsianpu · 2025-07-09T15:30:29Z

No description provided.

NordicBuilder · 2025-07-09T15:31:46Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
mcuboot	nrfconnect/sdk-mcuboot@`6256d9f` (`main`)	nrfconnect/sdk-mcuboot#461	nrfconnect/sdk-mcuboot#461/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-07-09T15:32:55Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 14

Inputs:

Sources:

sdk-nrf: PR head: e56bb8bc2af9fb94dd0fc6d1dfe0a7047eac557e
mcuboot: PR head: 64352790f0b41b13195a7011ed8d0f68310afb14

more details

sdk-nrf:

PR head: e56bb8bc2af9fb94dd0fc6d1dfe0a7047eac557e
merge base: 50c7cef2422ad794c8856778e9895da158b00fb6
target head (main): 50c7cef2422ad794c8856778e9895da158b00fb6
Diff

mcuboot:

PR head: 64352790f0b41b13195a7011ed8d0f68310afb14
merge base: 6256d9f6df644231fd196c94a5a92f23c1ad24d4
target head (main): 6256d9f6df644231fd196c94a5a92f23c1ad24d4
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (7)

bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── src
│  │  │  │  │  │ loader.c
│  │  │  ├── zephyr
│  │  │  │  │ Kconfig
cmake
│  ├── sysbuild
│  │  ├── b0_mcuboot_signing.cmake
│  │  ├── image_signing.cmake
│  │  │ image_signing_firmware_loader.cmake
sysbuild
│  │ CMakeLists.txt
west.yml

Outputs:

Toolchain

Version: f66cf421f3
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f66cf421f3_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
❌ Integration tests
- ✅ test-sdk-audio
- ✅ desktop52_verification
- ✅ test-fw-nrfconnect-apps
- ❌ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_mesh
- ✅ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-nrf_crypto
- ✅ test-fw-nrfconnect-proprietary_esb
- ✅ test-fw-nrfconnect-rpc
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-tfm
- ✅ test-fw-nrfconnect-thread-main
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf_lrcs_mosh
- ✅ test-fw-nrfconnect-nrf_lrcs_positioning
- ✅ test-sdk-wifi
- ✅ test-low-level
- ✅ test-sdk-pmic-samples
- ❌ test-sdk-mcuboot
- ✅ test-sdk-dfu
- ✅ test-fw-nrfconnect-ps-main
- ✅ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-07-09T15:56:43Z

You can find the documentation preview for this PR here.

nvlsianpu · 2025-07-24T11:59:35Z

@@ -85,11 +87,9 @@ function(zephyr_mcuboot_tasks)
    set(imgtool_sign ${PYTHON_EXECUTABLE} ${IMGTOOL} sign --version ${CONFIG_MCUBOOT_IMGTOOL_SIGN_VERSION} --align ${write_block_size} ${imgtool_sign_sysbuild})
  else()
    set(imgtool_rom_command)


Suggested change

set(imgtool_rom_command)

nordicjm · 2025-07-24T12:17:00Z

      dt_chosen(code_partition PROPERTY "zephyr,code-partition")
      dt_reg_addr(code_partition_offset PATH "${code_partition}" REQUIRED)
      set(imgtool_rom_command --rom-fixed ${code_partition_offset})


un-indent by 2 spaces

NordicBuilder · 2025-08-26T00:37:26Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

NordicBuilder · 2025-10-07T14:14:03Z

Memory footprint analysis revealed the following potential issues

applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 9102[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 5858[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus)
applications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High ROM usage: 9492[B] - link (cc: @nrfconnect/ncs-ll-ursus)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23242/14)

From now each image has populated fixed rom address in its header. This sets fixed-rom flag and populated ih_load_address field in the header. This value can be used by MCUboot for deciding on image. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

… value signing script on loader misses exact value for --rom-fixed parameter. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

version which can use rom-fixed address for recognizing images. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

github-actions · 2025-12-31T00:41:51Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

nvlsianpu requested review from a team as code owners July 9, 2025 15:30

github-actions Bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 9, 2025

NordicBuilder added manifest-mcuboot DNM labels Jul 9, 2025

nordicjm reviewed Jul 14, 2025

View reviewed changes

Comment thread cmake/sysbuild/image_signing.cmake Outdated

nvlsianpu force-pushed the signing-rom-fixed-all branch 3 times, most recently from 4011874 to b91ac43 Compare July 24, 2025 11:58

nvlsianpu commented Jul 24, 2025

View reviewed changes

nordicjm reviewed Jul 24, 2025

View reviewed changes

NordicBuilder added the Stale label Aug 26, 2025

github-actions Bot closed this Sep 3, 2025

nvlsianpu reopened this Sep 24, 2025

de-nordic force-pushed the signing-rom-fixed-all branch from b91ac43 to ed6594d Compare September 24, 2025 16:00

de-nordic removed the Stale label Sep 24, 2025

de-nordic force-pushed the signing-rom-fixed-all branch 8 times, most recently from 741ae76 to 47c69de Compare October 7, 2025 12:40

de-nordic force-pushed the signing-rom-fixed-all branch from 47c69de to b99e201 Compare October 7, 2025 14:11

de-nordic force-pushed the signing-rom-fixed-all branch 2 times, most recently from 37728f8 to 546da60 Compare October 7, 2025 14:22

nvlsianpu added 3 commits October 10, 2025 19:20

cmake/sysbuild/image_signing_firmware_loader: fix missing img address…

0151a82

… value signing script on loader misses exact value for --rom-fixed parameter. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

manifest: update mcuboot

e56bb8b

version which can use rom-fixed address for recognizing images. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>

de-nordic force-pushed the signing-rom-fixed-all branch from 546da60 to e56bb8b Compare October 10, 2025 19:27

NordicBuilder requested review from a team October 10, 2025 19:28

nordicjm approved these changes Oct 13, 2025

View reviewed changes

github-actions Bot added the Stale label Dec 31, 2025

github-actions Bot closed this Feb 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmake/sysbuild/image_signing: allow usage --rom-fixed for images target partition recognition#23242

cmake/sysbuild/image_signing: allow usage --rom-fixed for images target partition recognition#23242
nvlsianpu wants to merge 3 commits into
nrfconnect:mainfrom
nvlsianpu:signing-rom-fixed-all

nvlsianpu commented Jul 9, 2025

Uh oh!

NordicBuilder commented Jul 9, 2025 •

edited

Loading

Uh oh!

NordicBuilder commented Jul 9, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 9, 2025

Uh oh!

Uh oh!

nvlsianpu Jul 24, 2025

Uh oh!

nordicjm Jul 24, 2025

Uh oh!

NordicBuilder commented Aug 26, 2025

Uh oh!

NordicBuilder commented Oct 7, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nvlsianpu commented Jul 9, 2025

Uh oh!

NordicBuilder commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions Bot commented Jul 9, 2025

Uh oh!

Uh oh!

nvlsianpu Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Aug 26, 2025

Uh oh!

NordicBuilder commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory footprint analysis revealed the following potential issues

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NordicBuilder commented Jul 9, 2025 •

edited

Loading

NordicBuilder commented Jul 9, 2025 •

edited

Loading

NordicBuilder commented Oct 7, 2025 •

edited

Loading