cmake: Support manifest for non-partition-manager #24910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nRF54H20 does not use partition manager, only Zephyr device tree fixed
partitions. This causes a very niche issue when attempting to use the
DFU zip payload with nRF Connect Device Manager mobile apps- the
manifest contained in the DFU archive fails to parse, due to the
subimage offset being a string instead of a JSON number:
❯ cat build/dfu_application.zip_manifest.json
{
"format-version": 1,
"time": 1759849455,
"files": [
{
"type": "application",
"board": "nrf54h20dk",
"soc": "nrf54h20",
"load_address": "235143168", <- string, not number
"image_index": "0",
"slot_index_primary": "1",
"slot_index_secondary": "2",
"version_MCUBOOT": "0.0.0+0",
"size": 208100,
"file": "peripheral_mds.signed.bin",
"modtime": 1759849455
},
Adjust the value extracted from DT in the case where partition manager
is not used, when generating the DFU zip artifact, so it correctly
produces a number for the field in question.
❯ cat build/dfu_application.zip_manifest.json
{
"format-version": 1,
"time": 1759845147,
"files": [
{
"type": "application",
"board": "nrf54h20dk",
"soc": "nrf54h20",
"load_address": 235143168, <- number, not string 🎉
"image_index": "0",
"slot_index_primary": "1",
"slot_index_secondary": "2",
"version_MCUBOOT": "0.0.0+0",
"size": 220164,
"file": "peripheral_mds.signed.bin",
"modtime": 1759845134
},
Note that I'm only solving the immediate issue- there are other fields
in the manifest that look like numbers, but are strings, and in order
to not cause unintended side-effects, I'm only fixing the known problem.
Signed-off-by: Noah Pendleton <[email protected]>
NordicBuilder
added
the
changelog-entry-required
Contributor
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 32bf3d413f6f80bde5cb1b34e0c1d3df53816445 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: f66cf421f3 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Contributor
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24910/1) |
tejlmand
approved these changes
Oct 10, 2025
Contributor
Author
|
fixed in #24792 , closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nRF54H20 does not use partition manager, only Zephyr device tree fixed partitions. This causes a very niche issue when attempting to use the DFU zip payload with nRF Connect Device Manager mobile apps- the manifest contained in the DFU archive fails to parse, due to the subimage offset being a string instead of a JSON number:
Adjust the value extracted from DT in the case where partition manager is not used, when generating the DFU zip artifact, so it correctly produces a number for the field in question.
Note that I'm only solving the immediate issue- there are other fields in the manifest that look like numbers, but are strings, and in order to not cause unintended side-effects, I'm only fixing the known problem.