Skip to content

Conversation

@ahasztag
Copy link
Contributor

This commit fixes sample.mcumgr.smp_svr.bt.nrf54l15dk.ext_flash for nRF54L05 and nRF54L15

It is achieved by removing the partition definitions from the nrf54L ext flash overlay.
They are no longer needed, as the pure DTS configuration is no longer supported on nRF54L. They also caused issues, as they were not compatible with nRF54L10 and nRF54L05.

It renames nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay to nrf54l15dk_ext_flash.overlay, as now the same configuration can be used on nRF54L15, nRF54L10 and nRF54L05.

@ahasztag ahasztag requested review from a team as code owners October 15, 2025 12:09
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 15, 2025
@ahasztag ahasztag requested a review from nordic-piks October 15, 2025 12:09
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 15, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 15, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: e4444c9ef1cdab7d7447c150a9123fb1ef879154

more details

sdk-nrf:

PR head: e4444c9ef1cdab7d7447c150a9123fb1ef879154
merge base: 502e8f17dd3b69957e2a3489d3ab13a429241635
target head (main): bcff2f0fc4d26196344fb0ec1ac6e7d3349c22aa
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
samples
│  ├── zephyr
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── smp_svr
│  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  ├── nrf54l15dk_ext_flash.overlay
│  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
│  │  │  │  │  │  │ sample.yaml
scripts
│  │ quarantine.yaml

Outputs:

Toolchain

Version: 46667c6630
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:46667c6630_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 10
  • ✅ Integration tests
    • ✅ test-sdk-dfu
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-piks
Copy link
Contributor

Checked at CI, working fine.

@ahasztag ahasztag force-pushed the NCSDK-35694_fix_smp_svr_ext_flash_nrf54l05 branch from 3bff026 to 3c12041 Compare October 16, 2025 10:33
@NordicBuilder NordicBuilder requested review from a team October 16, 2025 10:34
@github-actions
Copy link

You can find the documentation preview for this PR here.

@carlescufi
Copy link
Contributor

@ahasztag can you please close the PR automatically created by the action? #25053. You can use the skip manifest label to avoid duplicating those. Thanks!

@nvlsianpu
Copy link
Contributor

@ahasztag you can update SHA.

This commit fixes sample.mcumgr.smp_svr.bt.nrf54l15dk.ext_flash
for nRF54L05 and nRF54L15

It is achieved by removing the partition definitions
from the nrf54L ext flash overlay.
They are no longer needed, as the pure DTS configuration
is no longer supported on nRF54L. They also caused issues, as they
were not compatible with nRF54L10 and nRF54L05.

It renames nrf54l15dk_nrf54l15_cpuapp_ext_flash.overlay
to nrf54l15dk_ext_flash.overlay, as now the same configuration
can be used on nRF54L15, nRF54L10 and nRF54L05.

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag force-pushed the NCSDK-35694_fix_smp_svr_ext_flash_nrf54l05 branch from f0a4aaa to e4444c9 Compare October 20, 2025 08:38
@ahasztag ahasztag requested a review from a team as a code owner October 20, 2025 08:38
@github-actions
Copy link

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

@tomchy tomchy merged commit 469243a into nrfconnect:main Oct 20, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants