-
Notifications
You must be signed in to change notification settings - Fork 1.4k
scripts: ncs_create_board: Align all YAML files to the .yaml extension #25086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most, if not all, boards upstream use .yaml instead of .yml, do the same for boards generated by the tool. Signed-off-by: Carles Cufi <[email protected]>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 86b80dd6b931eee5c3e8ed9c0278b9ce3135874d more detailssdk-nrf:
Github labels
List of changed files detected by CI (9)
Outputs:ToolchainVersion: 46667c6630 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tmpl = env.get_template("board.yml.jinja2") | ||
with open(out_dir / f"board.yml", "w") as f: | ||
tmpl = env.get_template("board.yaml.jinja2") | ||
with open(out_dir / f"board.yaml", "w") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no board uses board.yaml
and it is not supported, yaml
is a glob for twister, yml
was used because twister won't look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch I missed this !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Most, if not all, boards upstream use .yaml instead of .yml, do the same for boards generated by the tool.