samples: nrf_rpc: ps: Support for disabling RPC communication #25160

MarekPorwisz · 2025-10-21T13:48:08Z

Added support for stopping and restoring the RPC communication.
See also nrfconnect/sdk-nrfxlib#1886

If the RPC server becomes unresponsive it needs to be reset. In order to do this apart from releasing all the client threads waiting, callback tables need to be cleared as well.
Added cleanup handler registration that clears entire callback table when RPC communication is stopped.

NordicBuilder · 2025-10-21T13:54:32Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: 6439e00e806dbf27b44f9f90d1936e4f35e0d9cd
nrfxlib: PR head: 545ef5d19d2e1d1d7a9d4e0cf238c5164dfaac14

more details

sdk-nrf:

PR head: 6439e00e806dbf27b44f9f90d1936e4f35e0d9cd
merge base: 556216922de768e93a25661a58af70f2453375db
target head (main): e081cf5b33f6c691e43fde0bda257187c3fc5ec0
Diff

nrfxlib:

PR head: 545ef5d19d2e1d1d7a9d4e0cf238c5164dfaac14
merge base: 1d88c4484f24820c7cad542916080f409db9257d
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (5)

nrfxlib
│  ├── nrf_rpc
│  │  ├── include
│  │  │  │ nrf_rpc.h
│  │  │ nrf_rpc.c
samples
│  ├── nrf_rpc
│  │  ├── protocols_serialization
│  │  │  ├── client
│  │  │  │  ├── src
│  │  │  │  │  │ rpc_utils_shell.c
subsys
│  ├── nrf_rpc
│  │  │ nrf_rpc_cbkproxy.c
west.yml

Outputs:

Toolchain

Version: cfa6b06338
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:cfa6b06338_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 10
✅ Integration tests
- ✅ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps-main - Skipped: Job was skipped as it succeeded in a previous run

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2025-10-21T13:54:46Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`1d88c44`	nrfconnect/sdk-nrfxlib@`545ef5d` (`main`)	nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

github-actions · 2025-10-21T14:29:44Z

You can find the documentation preview for this PR here.

kderda · 2025-10-22T12:04:31Z

subsys/nrf_rpc/nrf_rpc_os.c

 	msg->data = data;
 	msg->len = len;
 	(void)k_condvar_signal(&msg->event);
+


accidental newline?

kderda · 2025-10-22T12:11:44Z

samples/nrf_rpc/protocols_serialization/client/src/rpc_utils_shell.c

 #if defined(CONFIG_NRF_RPC_UTILS_SYSTEM_HEALTH)
 	SHELL_CMD_ARG(system_health, NULL, "Get system health", cmd_system_health, 0, 0),
 #endif
+	SHELL_CMD_ARG(rpc, NULL, "Control RPC subsystem ", cmd_rpc, 2, 0),


Using rpc as subcommand would result in usage like: rpc rpc 1, maybe we can use something like control? e.g. rpc control enable/disable (these are parsed properly by shell_strtobool())

kderda · 2025-10-22T12:41:03Z

samples/nrf_rpc/protocols_serialization/client/src/rpc_utils_shell.c

+	if (argc > 1) {
+		bool enable;
+
+		enable = shell_strtobool(argv[1], 10, &err);


The call can be moved to declaration of bool enable above

kderda · 2025-10-22T12:45:02Z

samples/nrf_rpc/protocols_serialization/client/src/rpc_utils_shell.c


+static int cmd_rpc(const struct shell *sh, size_t argc, char *argv[])
+{
+	static bool enabled;


Wouldn't it be initialized to false before the first call so if you call the command without any argument it will say that RPC is disabled despite it is succesfuly running?

kderda · 2025-10-22T12:46:10Z

subsys/nrf_rpc/nrf_rpc_cbkproxy.c


 static uint32_t next_free_in_slot;

+void ot_rpc_cbproxy_clear(void *context)


It can be static

Damian-Nordic · 2025-10-23T07:31:08Z

subsys/nrf_rpc/nrf_rpc_cbkproxy.c


 static uint32_t next_free_in_slot;

+static void ot_rpc_cbproxy_clear(void *context)


This feature is not limited to OT, so the naming is confusing.

Added functions to stop and restore RPC communication. Stopping the communication automatically times out all pending tasks and prevents new communication. Init messages, errors and acks are still allowed. This is intended to allow smooth recovery after failures. Additionally all calbacks that use common API may be cleared. Signed-off-by: Marek Porwisz <[email protected]>

MarekPorwisz requested review from a team as code owners October 21, 2025 13:48

NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 21, 2025

NordicBuilder added manifest-nrfxlib DNM labels Oct 21, 2025

MarekPorwisz force-pushed the rpc_cleanup_callbacks branch 3 times, most recently from 08b0a7c to 957f474 Compare October 22, 2025 12:17

kderda reviewed Oct 22, 2025

View reviewed changes

MarekPorwisz force-pushed the rpc_cleanup_callbacks branch from 957f474 to 885201f Compare October 22, 2025 13:11

NordicBuilder requested a review from a team October 22, 2025 13:11

Damian-Nordic reviewed Oct 23, 2025

View reviewed changes

MarekPorwisz force-pushed the rpc_cleanup_callbacks branch from 885201f to b2d9731 Compare October 23, 2025 09:10

NordicBuilder requested a review from a team October 23, 2025 09:10

kderda approved these changes Oct 23, 2025

View reviewed changes

rlubos mentioned this pull request Oct 24, 2025

manifest: sdk-nrfxlib: rpc: Implement possibility to stop and resume all the RPC communication #25159

Closed

MarekPorwisz force-pushed the rpc_cleanup_callbacks branch from b2d9731 to 6439e00 Compare October 24, 2025 07:42

NordicBuilder requested a review from a team October 24, 2025 07:43

rlubos approved these changes Oct 24, 2025

View reviewed changes

NordicBuilder removed the DNM label Oct 24, 2025

rlubos merged commit d349cf8 into nrfconnect:main Oct 24, 2025
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

samples: nrf_rpc: ps: Support for disabling RPC communication #25160

samples: nrf_rpc: ps: Support for disabling RPC communication #25160

Uh oh!

MarekPorwisz commented Oct 21, 2025

Uh oh!

NordicBuilder commented Oct 21, 2025 •

edited

Loading

Uh oh!

NordicBuilder commented Oct 21, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

kderda Oct 22, 2025

Uh oh!

kderda Oct 22, 2025

Uh oh!

kderda Oct 22, 2025

Uh oh!

kderda Oct 22, 2025

Uh oh!

kderda Oct 22, 2025

Uh oh!

Damian-Nordic Oct 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		static uint32_t next_free_in_slot;

		void ot_rpc_cbproxy_clear(void *context)


		static uint32_t next_free_in_slot;

		static void ot_rpc_cbproxy_clear(void *context)

samples: nrf_rpc: ps: Support for disabling RPC communication #25160

samples: nrf_rpc: ps: Support for disabling RPC communication #25160

Uh oh!

Conversation

MarekPorwisz commented Oct 21, 2025

Uh oh!

NordicBuilder commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

NordicBuilder commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

kderda Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kderda Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kderda Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kderda Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

kderda Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Damian-Nordic Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NordicBuilder commented Oct 21, 2025 •

edited

Loading

NordicBuilder commented Oct 21, 2025 •

edited

Loading