Skip to content

Conversation

@57300
Copy link
Contributor

@57300 57300 commented Oct 29, 2025

No description provided.

@57300 57300 requested review from a team as code owners October 29, 2025 14:01
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 29, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 29, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
oberon-psa-crypto nrfconnect/sdk-oberon-psa-crypto@c79b47b (main) nrfconnect/sdk-oberon-psa-crypto#32 nrfconnect/sdk-oberon-psa-crypto#32/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 29, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 4cba24ae4098a3cdbdda66163bda40331356f192
oberon-psa-crypto: PR head: e7f3c3b0e1f683996f61b01be46c1b064a09554b

more details

sdk-nrf:

PR head: 4cba24ae4098a3cdbdda66163bda40331356f192
merge base: 1a6e672180a2817a81563c13a2d5f9c3e643a80e
target head (main): 35246387d4fdc7e84615716a068a57afca940ce2
Diff

oberon-psa-crypto:

PR head: e7f3c3b0e1f683996f61b01be46c1b064a09554b
merge base: c79b47bcf201b543c20c74dafb32194e3ccc9677
target head (main): c79b47bcf201b543c20c74dafb32194e3ccc9677
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
modules
│  ├── crypto
│  │  ├── oberon-psa-crypto
│  │  │  ├── library
│  │  │  │  │ psa_crypto.c
west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 2073
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-tfm
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

You can find the documentation preview for this PR here.

@57300 57300 force-pushed the ironside-crypto-driver branch 2 times, most recently from 317bf25 to 76d9972 Compare October 30, 2025 23:27
help
PSA crypto driver for the CRACEN HW peripheral.

config PSA_CRYPTO_DRIVER_IRONSIDE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that it makes sense to not have the _SE suffix here since it could act as a wrapper for different platforms with differente IronSide variants.

@57300 57300 force-pushed the ironside-crypto-driver branch from 76d9972 to aaa75b9 Compare October 31, 2025 09:17
@NordicBuilder NordicBuilder requested a review from a team October 31, 2025 09:18
@57300 57300 requested a review from hakonfam October 31, 2025 09:18
@tomi-font
Copy link
Contributor

Is this PR abandoned in favor of #25368? please clarify

@57300
Copy link
Contributor Author

57300 commented Nov 4, 2025

Is this PR abandoned in favor of #25368? please clarify

Not quite. I understand that the Oberon patch needs more review time, so I was hoping to have the NCS changes merged first. This PR will be rebased soon.

@57300 57300 changed the title Ironside crypto driver manifest: Update Oberon Nov 7, 2025
Bump the sdk-oberon-psa-crypto revision.

Signed-off-by: Grzegorz Swiderski <[email protected]>
Copilot AI review requested due to automatic review settings November 7, 2025 12:06
@57300 57300 force-pushed the ironside-crypto-driver branch from aaa75b9 to 4cba24a Compare November 7, 2025 12:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the oberon-psa-crypto module to point to a pull request reference instead of a specific commit hash, likely for testing or integration purposes before a formal release.

  • Updates the oberon-psa-crypto module revision from a commit SHA to a PR reference

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

path: modules/crypto/oberon-psa-crypto
repo-path: sdk-oberon-psa-crypto
revision: c79b47bcf201b543c20c74dafb32194e3ccc9677
revision: pull/32/head
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a pull request reference (pull/32/head) as a revision in a manifest file is not recommended for production or stable branches. PR references are mutable and can change as the PR is updated, leading to inconsistent builds. Consider using a specific commit SHA or a tagged release once the changes are finalized.

Suggested change
revision: pull/32/head
revision: <COMMIT_SHA>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-oberon-psa-crypto manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants