-
Notifications
You must be signed in to change notification settings - Fork 1.4k
nRF Desktop: application module update after the IronSide SE migration #25461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,8 +69,11 @@ Make sure that the DFU lock utility is enabled if your nRF Desktop application c | |
| You cannot use this module with the :ref:`caf_ble_smp`. | ||
| In other words, you cannot simultaneously enable the :ref:`CONFIG_DESKTOP_DFU_MCUMGR_ENABLE <config_desktop_app_options>` option and the :kconfig:option:`CONFIG_CAF_BLE_SMP` Kconfig option. | ||
|
|
||
| Currently, this module supports only one bootloader backend, the MCUboot bootloader backend. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would skip this sentence as it's already part of the note below |
||
|
|
||
| .. note:: | ||
| B0 bootloader is not integrated with MCUmgr. | ||
| Currently, this module supports only one bootloader backend, the MCUboot bootloader backend. | ||
| B0 bootloader is not integrated with MCUmgr. | ||
|
|
||
| .. _nrf_desktop_dfu_mcumgr_mcuboot: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -364,6 +364,9 @@ nRF5340 Audio | |
| nRF Desktop | ||
| ----------- | ||
|
|
||
| * Added support for the DTS-based memory layout in the :ref:`nrf_desktop_dfu`. | ||
| This layout is only supported for the MCUboot bootloader. | ||
|
|
||
| * Updated: | ||
|
|
||
| * The memory layouts for the ``nrf54lm20dk/nrf54lm20a/cpuapp`` board target to make more space for the application code. | ||
|
|
@@ -408,6 +411,9 @@ nRF Desktop | |
| * Application image configurations to explicitly specify the LED driver used by the :ref:`nrf_desktop_leds` (:kconfig:option:`CONFIG_CAF_LEDS_GPIO` or :kconfig:option:`CONFIG_CAF_LEDS_PWM`). | ||
| Also, disabled unused LED drivers enabled by default to reduce memory footprint. | ||
| * The :ref:`nrf_desktop_hid_forward` to allow using the module when configuration channel support (:ref:`CONFIG_DESKTOP_CONFIG_CHANNEL_ENABLE <config_desktop_app_options>`) is disabled in the application configuration. | ||
| * The :ref:`nrf_desktop_dfu` and the :ref:`nrf_desktop_dfu_mcumgr` to handle the ``nrf54h20dk/nrf54h20/cpuapp`` board target with the IronSide SE architecture and the MCUboot bootloader. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the doc pages be updated with the IronSide SE details?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think so. This is the documentation of the IronSide component, which we do not change. I think we should just document the nRF Desktop integration with IronSide (or in other words: how we use IronSide in our application).
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a plan to update the migration guide as well. Will that be done as part of this PR or a separate PR?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this PR is one of many for the related JIRA ticket. I plan to contribute the nRF Desktop migration guide at the very end |
||
|
|
||
| * Removed the SUIT support from the :ref:`nrf_desktop_dfu` and the :ref:`nrf_desktop_dfu_mcumgr`. | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have mention about suit in the Board configuration docs here : https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/applications/nrf_desktop/board_configuration.html#nrf_desktop_board_configuration_files. Could remove those line as well? Also, the note about IronSide SE migration at the end of the page.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will be done in a follow-up PR. This PR focuses only on the application modules from the nRF Desktop app. |
||
| nRF Machine Learning (Edge Impulse) | ||
| ----------------------------------- | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to provide a bit more context why partitioning is relevant for this module. I would also suggest to remove some duplication. Maybe we could use something similar to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we could even skip this section as the information is covered in line 42:
You could just add information that
The module is compatible with memory layout defined in either Partition Manager or DTS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section would probably be extended if we proceed with the RAM load mode of MCUboot in the context of LM20. Due to this, I would desist from removing this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add an introductory sentence, as I think it is a good improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's another reason why we should avoid duplicating information. Maybe we could remove the "generic information" from this doc page and update the
nrf_desktop_memory_layoutdoc page (we need to do it anyway).