Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Nov 13, 2025

Result of invalidation changed log level from error to debug.

Replacement for: #25385

Result of invalidation changed log level from error to debug.

Signed-off-by: Mateusz Michalek <[email protected]>
pull in kmu revocation tests adjustments.

Signed-off-by: Mateusz Michalek <[email protected]>
Copilot AI review requested due to automatic review settings November 13, 2025 15:55
@tomchy tomchy requested review from a team as code owners November 13, 2025 15:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MCUboot revision and adjusts test expectations to reflect a change in log level for key invalidation results from error to debug. The tests are modified to no longer expect the "Key invalidation failed with" error message in the output.

  • Updated MCUboot revision to 0d263faf6e55a697ee336f2fbef0af095802f979
  • Removed expectations for "Key invalidation failed with" log messages in KMU revoke tests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
west.yml Updated MCUboot revision reference
tests/subsys/bootloader/upgrade/pytest/test_kmu_extra.py Removed "Key invalidation failed with" from expected log output in two test functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 13, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 13, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/sdk-mcuboot@459288d nrfconnect/sdk-mcuboot@0d263fa (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 13, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: c544359a6382a161136c6b2a481416836806cc6c
mcuboot: PR head: 0d263faf6e55a697ee336f2fbef0af095802f979

more details

sdk-nrf:

PR head: c544359a6382a161136c6b2a481416836806cc6c
merge base: 63d179d50c029bf6fe690e911796f156a5d650f0
target head (main): 57ca0fdae35d090366fe396ea19accf0db985688
Diff

mcuboot:

PR head: 0d263faf6e55a697ee336f2fbef0af095802f979
merge base: 459288d6a13cede9fa09e314b21a979a6cc6e3f2
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── src
│  │  │  │  │  │ ed25519_psa.c
│  │  │  ├── zephyr
│  │  │  │  │ firmware_loader_bm.c
tests
│  ├── subsys
│  │  ├── bootloader
│  │  │  ├── upgrade
│  │  │  │  ├── pytest
│  │  │  │  │  │ test_kmu_extra.py
west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 4
  • ✅ Integration tests
    • ✅ test-sdk-mcuboot
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copilot AI review requested due to automatic review settings November 13, 2025 16:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Make all changes, necessary to pass ruff checks.

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@github-actions
Copy link

You can find the documentation preview for this PR here.

@rlubos rlubos merged commit a7df2a4 into nrfconnect:main Nov 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-mcuboot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants