Skip to content

Conversation

@tomchy
Copy link
Contributor

@tomchy tomchy commented Nov 26, 2025

Enable HW rollback protection in the A/B split slot sample.

Copilot AI review requested due to automatic review settings November 26, 2025 19:14
@tomchy tomchy requested review from a team as code owners November 26, 2025 19:14
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables hardware-based rollback protection in the A/B split slot DFU sample by integrating the IronSide counter service with MCUboot. The changes update dependency revisions and add necessary configuration options.

  • Updates Zephyr and MCUboot dependencies to pull request branches that support IronSide counters
  • Enables IronSide counter service in MCUboot configuration
  • Activates hardware-based downgrade prevention in the sysbuild configuration

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
west.yml Updates Zephyr and MCUboot revisions to pull request branches
samples/dfu/ab_split/sysbuild/mcuboot/prj.conf Enables IronSide counter service and MCUboot IronSide counter implementation
samples/dfu/ab_split/sysbuild.conf Enables hardware-based downgrade prevention configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 26, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@dc05376 (main) nrfconnect/sdk-zephyr#3545 nrfconnect/sdk-zephyr#3545/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 26, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 5e0239c45c34257fbfbab7c89211e7da529232cc
zephyr: PR head: d4878ac7900e6e04cc735fed6d2b562e5cffa917

more details

sdk-nrf:

PR head: 5e0239c45c34257fbfbab7c89211e7da529232cc
merge base: 0c79406a493836eff01af3bf4a75b49a5a47ca16
target head (main): 0c79406a493836eff01af3bf4a75b49a5a47ca16
Diff

zephyr:

PR head: d4878ac7900e6e04cc735fed6d2b562e5cffa917
merge base: dc05376c170fc2739a4881629caf49c40d485a9e
target head (main): dc05376c170fc2739a4881629caf49c40d485a9e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7)
samples
│  ├── dfu
│  │  ├── ab_split
│  │  │  ├── sysbuild.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  │ prj.conf
west.yml
zephyr
│  ├── soc
│  │  ├── nordic
│  │  │  ├── ironside
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── counter.c
│  │  │  │  ├── include
│  │  │  │  │  ├── nrf_ironside
│  │  │  │  │  │  │ counter.h

Outputs:

Toolchain

Version: 964ddb2c70
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:964ddb2c70_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 1828
    • sdk-zephyr test count: 460
  • ✅ Integration tests
    • ✅ test-sdk-audio
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-nfc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-thread-main
    • ✅ test-sdk-find-my
    • ✅ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tomchy tomchy added this to the 3.2.0 milestone Nov 26, 2025
@github-actions
Copy link

You can find the documentation preview for this PR here.

@shanthanordic
Copy link

PR not ready moving it out of 3.2.0 scope

@shanthanordic shanthanordic removed this from the 3.2.0 milestone Nov 27, 2025
Update sdk-zephyr repositories.

Ref: NCSDK-36359

Signed-off-by: Tomasz Chyrowicz <[email protected]>
Enable HW-based downgrade protection inside the A/B sample with split
slots.

Ref: NCSDK-36359

Signed-off-by: Tomasz Chyrowicz <[email protected]>
@tomchy tomchy force-pushed the bugfix/ironside/NCSDK-36359_Align_counter branch from 73e0585 to 5e0239c Compare November 27, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-mcuboot manifest-zephyr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants