USB CDC ACM serial firmware loader + dfu/single_slot sample project integration#27185
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: ff3782b4ad4744a5075854023d5990f60a949ced more detailssdk-nrf:
Github labels
List of changed files detected by CI (13)Outputs:ToolchainVersion: 911f4c5c26 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsbmdoc.z6.web.core.windows.net/ncs/PR-27185/nrf/releases_and_maturity/releases/release-notes-changelog.html |
3072221 to
189ffda
Compare
| @@ -0,0 +1,40 @@ | |||
| mcuboot: | |||
There was a problem hiding this comment.
This partition manager file seems only to be necessary for building the usb_mcumgr fw_loader as a standalone application - it is not used if the fw_loader is used by an outside application.
Can't we use devicetree for building the standalone application?
There was a problem hiding this comment.
This sample is not intended to function as a standalone sample.
| */ | ||
|
|
||
| / { | ||
| chosen { |
There was a problem hiding this comment.
It seems this file won't be necessary at all in case of the dongle due to the line (this will already be done by default on the dongle):
This all will happen automatically there.
Perhaps here you should also simply include the file from zephyr: boards/common/usb/cdc_acm_serial.dtsi for the DK
Also - take a look at
- perhaps some of the configuration from prj.conf won't be needed (although I doubt it)There was a problem hiding this comment.
In case of the dongle configuration will be more complex (firmware_loader) that this and what you pointed:
- dedicated cdc_acm_uart assigned for SMP MCUmgr
- dedicated cdc_acm_uart assigned for LOG
|
Changelog entry missing. |
cfaecd7 to
8d8b140
Compare
|
|
||
| cmake_minimum_required(VERSION 3.20.0) | ||
| find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE}) | ||
| project(ble_mcumgr) |
| CONFIG_COMMON_LIBC_MALLOC=y | ||
| CONFIG_LOG=n | ||
|
|
||
| CONFIG_UART_CONSOLE=n #? Why is this disabled? |
| # Enable the mcumgr Packet Reassembly feature over Bluetooth and its configuration dependencies. | ||
| # MCUmgr buffer size is optimized to fit one SMP packet divided into five Bluetooth Write Commands, | ||
| # transmitted with the maximum possible MTU value: 247 bytes. | ||
| #CONFIG_MCUMGR_TRANSPORT_BT_REASSEMBLY=y |
There was a problem hiding this comment.
why does this file contain complete irrelevant comments?
| CONFIG_DEVICE_SHELL=n | ||
| CONFIG_DEVMEM_SHELL=n | ||
| CONFIG_FLASH_SHELL=n | ||
| ######## |
There was a problem hiding this comment.
| CONFIG_BASE64=y | ||
| CONFIG_CRC=y | ||
|
|
||
| # Enable the mcumgr Packet Reassembly feature over Bluetooth and its configuration dependencies. |
56048b6 to
b5ea6a9
Compare
f0e12bd to
da355e9
Compare
f117f96 to
41fca30
Compare
41fca30 to
e525613
Compare
FrancescoSer
left a comment
There was a problem hiding this comment.
Approving but implement these suggestions
e525613 to
5a15a68
Compare
27de1b1 to
9a619d0
Compare
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12662[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-27185/37) |
Added USB CDC-ACM (Virtual COM) SMP MCUmgr firmware loader project, so it will be aveilable as firmware loader image. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Added SB_CONFIG_FIRMWARE_LOADER_IMAGE_USB_MCUMGR option which enables USB CDC-ACM firmware loader for a build. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Added configuration which allow to build the sample with USB CDC-ACM SMP MCUmgr firmeare loader. This can be build for nRF54LM20DK with FILE_SUFFIX=usb. Somewhy when building on Windows machine with FILE_SUFFIX=usb need to create sysbuild/usb_mcumgr image configuration explicitelly. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Updated doc for covering building and testing the sample with USB CDC ACM firmware loader. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Add link to nRFUtil mcumanager page. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Doc added (pattern for ble_mcumgr repalyed). Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Added reevant records on usb cdc acm smp mcumgr support in NCS. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no> Signed-off-by: Francesco Domenico Servidio <francesco.servidio@nordicsemi.no>
9a619d0 to
ff3782b
Compare
ref.: NCSDK-37252
next steep PR:
dfu/single_slot: Application entering fw_loader via USB MCUmgr