samples/dfu/firmware_loader: common partitioning of nrf54lm20dongle#28154
Conversation
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: d46f27a764efe0e3327a220dba0d23b4d3928bba more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 53ac68dd62 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
| /delete-node/ &boot_partition; | ||
| /delete-node/ &slot0_partition; |
There was a problem hiding this comment.
| /delete-node/ &boot_partition; | |
| /delete-node/ &slot0_partition; |
| reg = <0x0 DT_SIZE_K(2036)>; | ||
| ranges = <0x0 0x0 DT_SIZE_K(2036)>; | ||
|
|
There was a problem hiding this comment.
| reg = <0x0 DT_SIZE_K(2036)>; | |
| ranges = <0x0 0x0 DT_SIZE_K(2036)>; |
| compatible = "fixed-partitions"; | ||
| #address-cells = <1>; | ||
| #size-cells = <1>; | ||
|
|
||
| /* Matches board layout */ | ||
| boot_partition: partition@0 { | ||
| label = "mcuboot"; | ||
| reg = <0x0 DT_SIZE_K(24)>; | ||
| }; | ||
|
|
||
| /* Matches board layout */ | ||
| slot1_partition: partition@6000 { | ||
| label = "image-1"; | ||
| reg = <0x6000 DT_SIZE_K(116)>; | ||
| }; | ||
|
|
||
| /* Start matches board layout */ |
There was a problem hiding this comment.
| compatible = "fixed-partitions"; | |
| #address-cells = <1>; | |
| #size-cells = <1>; | |
| /* Matches board layout */ | |
| boot_partition: partition@0 { | |
| label = "mcuboot"; | |
| reg = <0x0 DT_SIZE_K(24)>; | |
| }; | |
| /* Matches board layout */ | |
| slot1_partition: partition@6000 { | |
| label = "image-1"; | |
| reg = <0x6000 DT_SIZE_K(116)>; | |
| }; | |
| /* Start matches board layout */ |
There was a problem hiding this comment.
I guess it can be simplified even more as I did in https://github.com/nrfconnect/sdk-nrf/pull/27984/changes#diff-3cbd7af71ec3cb38da7c96430337355519d1064223bc20b549f4d359f24acfe8.
| /delete-node/ &boot_partition; | ||
| /delete-node/ &slot0_partition; | ||
| /delete-node/ &slot1_partition; | ||
| /delete-node/ &storage_partition; |
There was a problem hiding this comment.
this file needs to be in the boards folder of both samples, samples must be self contained and allow copying out for vscode usability
There was a problem hiding this comment.
Ok, duplicated and moved accordingly.
87b9564 to
4a4fdfa
Compare
Damian-Nordic
left a comment
There was a problem hiding this comment.
Found a few minor spelling and grammar issues but LGTM overall.
| /* This is nRF54lm20dongle_nrf54lm20b_cpuapp peculiar partitioning for MCUboot and firmware loader | ||
| * slot0_partition spans RRAM with can be update by the firmware loader and booted by MCUboot. | ||
| * beginning of the slot0_partition must match with the beginning of the slot0_partition of the user | ||
| * application. Althought Application can be build for smaler partition and live some space for | ||
| * other purposes like a storage partition. |
There was a problem hiding this comment.
| /* This is nRF54lm20dongle_nrf54lm20b_cpuapp peculiar partitioning for MCUboot and firmware loader | |
| * slot0_partition spans RRAM with can be update by the firmware loader and booted by MCUboot. | |
| * beginning of the slot0_partition must match with the beginning of the slot0_partition of the user | |
| * application. Althought Application can be build for smaler partition and live some space for | |
| * other purposes like a storage partition. | |
| /* This is nRF54lm20dongle_nrf54lm20b_cpuapp-specific partitioning for MCUboot and firmware loader. | |
| * slot0_partition defines RRAM region which can be updated by the firmware loader and booted by MCUboot. | |
| * Beginning of the slot0_partition must match the beginning of the slot0_partition of the user | |
| * application, but the application can use a smaller partition and leave some space for | |
| * other purposes like a storage partition. |
4a4fdfa to
b6204f7
Compare
b6204f7 to
d9bf481
Compare
Added DTS overlay for partitions on nRF54LM20dongle. This is for firmware loader - slot0_parttion spans till end of RRAM. MCUboot Is (and must use same partitioning). An application build must keep the same start address but can downsize the partition. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
d9bf481 to
d46f27a
Compare
Added DTS overlay for partitions on nRF54LM20dongle.
This is for firmware loader - slot0_parttion spans till end of RRAM.
MCUboot Is (and must use same partitioning).
An application build must keep the same start address but
can downsize the partition.