Skip to content

[Backport v3.3-branch] bluetooth: cgms: racp: validate write length#28594

Merged
rlubos merged 1 commit into
v3.3-branchfrom
backport-28530-to-v3.3-branch
May 12, 2026
Merged

[Backport v3.3-branch] bluetooth: cgms: racp: validate write length#28594
rlubos merged 1 commit into
v3.3-branchfrom
backport-28530-to-v3.3-branch

Conversation

@NordicBuilder
Copy link
Copy Markdown
Contributor

Backport 0684d60 from #28530.

@NordicBuilder NordicBuilder requested a review from a team as a code owner May 7, 2026 07:04
@NordicBuilder
Copy link
Copy Markdown
Contributor Author

NordicBuilder commented May 7, 2026

CI Information

To view the history of this post, click the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 27a6c26c5c242f0292940aa0b74105bd427ca47a

more details

sdk-nrf:

PR head: 27a6c26c5c242f0292940aa0b74105bd427ca47a
merge base: 9eb0315565b95b894c2bd01f2697720df8dfcf51
target head (v3.3-branch): 9eb0315565b95b894c2bd01f2697720df8dfcf51
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
subsys
│  ├── bluetooth
│  │  ├── services
│  │  │  ├── cgms
│  │  │  │  ├── cgms.c
│  │  │  │  ├── cgms_internal.h
│  │  │  │  │ cgms_racp.c

Outputs:

Toolchain

Version: 911f4c5c26
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:911f4c5c26_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 639
  • ❌ Integration tests
    • ✅ desktop52_verification
    • ✅ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_samples
    • ✅ test-sdk-find-my
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@LuDuda LuDuda requested a review from Damian-Nordic May 7, 2026 07:48
@LuDuda LuDuda added the bugfix Fixes a known bug label May 7, 2026
@LuDuda LuDuda added this to the 3.3.1 milestone May 7, 2026
@LuDuda
Copy link
Copy Markdown
Contributor

LuDuda commented May 7, 2026

Depends on: #28603 for a CI fix.

Copy link
Copy Markdown

@shanthanordic shanthanordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for scope

@LuDuda LuDuda force-pushed the backport-28530-to-v3.3-branch branch from 47103ad to 3d390fb Compare May 8, 2026 11:22
Ensure incoming RACP characteristic writes are rejected with proper
ATT error codes before reaching internal processing the CGMS subsystem.

Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no>
(cherry picked from commit 0684d60)
@LuDuda LuDuda force-pushed the backport-28530-to-v3.3-branch branch from 3d390fb to 27a6c26 Compare May 11, 2026 08:04
@NordicBuilder
Copy link
Copy Markdown
Contributor Author

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zrelease[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 752[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-xcake)
sample.find_my.switchable_networks.release.dfu_switch[nrf54ls05dk@0.2.0/nrf54ls05b/cpuapp]: ROM size increased by 600[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[nrf54lm20dk/nrf54lm20b/cpuapp]: ROM size increased by 752[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-xcake)
applications.nrf_desktop.zrelease_ram_load[nrf54lm20dk/nrf54lm20b/cpuapp]: RAM size increased by 796[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-xcake)
applications.nrf_desktop.zrelease_ram_load[nrf54lm20dk/nrf54lm20b/cpuapp]: ROM size increased by 728[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-xcake)
sample.find_my.switchable_networks.release.dfu_switch[nrf52833dk/nrf52833]: ROM size increased by 624[B] in comparison to the main[70caff2] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-28594/3)

@rafpelc
Copy link
Copy Markdown
Contributor

rafpelc commented May 11, 2026

CI Integration failure was due to issue in downstream jenkins plan.
Ran tests separately from PR branch, results are positive: https://jenkins-ncs.nordicsemi.no/blue/organizations/jenkins/latest%2Ftest-fw-nrfconnect-ble_samples/detail/v3.3-branch/6/pipeline

From QA perspective regarding BLE Samples this PR can be merged

@rlubos rlubos merged commit 7cdfa30 into v3.3-branch May 12, 2026
18 of 19 checks passed
@rlubos rlubos deleted the backport-28530-to-v3.3-branch branch May 12, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants