modules: tf-m: improve logic for building Crypto partition - #30592
modules: tf-m: improve logic for building Crypto partition#30592tomi-font wants to merge 2 commits into
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 6216e1cb20a96e8e20e25c7fe48e073c6d65045c more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (11)Outputs:ToolchainVersion: 3d934a3d8a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Make sure that everything which needs the Crypto partition explicitly depends on it. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
To align with how it works when building without TF-M. At the same time remove a `depends on` because it had no effect on the upstream Kconfig option it was redefining. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
a75a14d to
6216e1c
Compare
|
You can find the documentation preview for this PR here. |
There was a problem hiding this comment.
Pull request overview
This PR aims to align TF-M builds with secure-only behavior by making the TF-M Crypto partition enablement follow PSA Crypto configuration (CONFIG_PSA_CRYPTO), so Crypto is brought in automatically when needed.
Changes:
- Updates the Zephyr module revision in
west.ymlto pick up required upstream behavior for TF-M/Crypto partition logic. - Adjusts TF-M Kconfig to better couple ITS encryption and minimal-profile crypto feature selections to whether PSA Crypto is enabled.
- Refactors TF-M minimal defconfig so Crypto-partition-related module options are only defined when the Crypto partition is enabled.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
west.yml |
Updates Zephyr revision to a PR ref to obtain upstream TF-M-related changes. |
modules/trusted-firmware-m/Kconfig.tfm.defconfig |
Removes an out-of-tree override of TFM_PARTITION_CRYPTO dependency behavior. |
modules/trusted-firmware-m/Kconfig.tfm_minimal.defconfig |
Reorders/guards minimal-profile crypto options under TFM_PARTITION_CRYPTO and adds a dependency gate. |
modules/trusted-firmware-m/Kconfig |
Gates encrypted ITS on Crypto partition and makes minimal profile PSA algorithm selects conditional on PSA_CRYPTO. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Align TF-M builds with their secure-only counterparts, enabling the Crypto partition automatically based on
CONFIG_PSA_CRYPTO.