nrf_rpc: remove sending from rx thread #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
canisLupus1313
approved these changes
Oct 2, 2024
Contributor
Author
|
@doki-nordic, @KAGA164 could any of you to take a look at changes? |
Commit removes any data sending over serial transport from rx thread and adds sending over allocated pool of threads for incoming data execution. The reason of this: if sending requires some acknowledgements then deadlock of rx thread happens. Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax
force-pushed
the
sync_rpc_start
branch
from
14c7b30 to
59a9c3d
Compare
Damian-Nordic
approved these changes
Oct 2, 2024
tomchy
added a commit
to tomchy/sdk-nrfxlib
that referenced
this pull request
Oct 29, 2024
In case of error, the group pointer may be set to NULL. This reverts part of changes introduced in the following PR: nrfconnect#1493 Ref: NCSDK-29976 Signed-off-by: Tomasz Chyrowicz <[email protected]>
tomchy
added a commit
to tomchy/sdk-nrf
that referenced
this pull request
Oct 29, 2024
Update sdk-nrfxlib revision. This reverts changes introduced in the following PRs: nrfconnect/sdk-nrfxlib#1493 nrfconnect/sdk-nrfxlib#1506 Ref: NCSDK-19976 Signed-off-by: Tomasz Chyrowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit removes any data sending over serial transport from rx thread and adds sending over allocated pool of threads for incoming data execution.
The reason of this: if sending requires some acknowledgements then deadlock of rx thread happens.