Revert "softdevice_controller: Fix doc build error" #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
krish2718
approved these changes
Oct 7, 2024
Contributor
krish2718
left a comment
krish2718
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Just to note, I did this to fix doc build error https://github.com/nrfconnect/sdk-nrf/actions/runs/10272673065/job/28425391631 but I lost the context about rephrasing.
Merged
This reverts commit 69cbe67. The commit message states that indentation was fixed, but the indentation did not change. The commit also changed phrasings unintentionally. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
revert-incorrect-doc-fix
branch
from
8df4cc2 to
d7a6aaa
Compare
hermabe
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 69cbe67. The commit message states that indentation was fixed, but the indentation did not change.
The commit also changed phrasings unintentionally.