Skip to content

Conversation

@NordicBuilder
Copy link
Contributor

CHANGELOG.rst contains the list of changes.

Signed-off-by: Olivier Lesage <[email protected]>
CHANGELOG.rst contains the list of changes.

Signed-off-by: Olivier Lesage <[email protected]>
@rugeGerritsen
Copy link
Contributor

#1582 already contains an updated lib. Needs to be merged together to avoid breaking main

@rugeGerritsen rugeGerritsen added the DNM Do not merge label Nov 27, 2024
@olivier-le-sage
Copy link
Contributor

olivier-le-sage commented Nov 27, 2024

#1582 already contains an updated lib. Needs to be merged together to avoid breaking main

this PR doesn't include Piotr's changes, and CI did run successfully. What exactly is it going to break?

@rugeGerritsen
Copy link
Contributor

It is going to delay nrfconnect/sdk-nrf#18981 which we want to avoid as this PR blocks other things

@olivier-le-sage
Copy link
Contributor

It is going to delay nrfconnect/sdk-nrf#18981 which we want to avoid as this PR blocks other things

so it's not breaking main.

@olivier-le-sage
Copy link
Contributor

the point of this PR is to fix the nightly:

just leaving this here in case anyone questions whether I tried to address the failures ASAP

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Mar 14, 2025
@github-actions github-actions bot closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DNM Do not merge Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants