crypto: Moving threading_alt.h to the CC3XX platform #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2025
manifest: sdk-nrfxlib: crypto: Moving threading_alt.h to the CC3XX platform
nrfconnect/sdk-nrf#19753
Closed
tomi-font
approved these changes
Jan 10, 2025
degjorva
approved these changes
Jan 13, 2025
The CC3XX platform contains the functions for mbedtls mutex handling: - mbedtls_mutex_init - mbedtls_mutex_free - mbedtls_mutex_lock - mbedtls_mutex_unlock These functions are not only used by the legacy mbedTLS APIs. They are also used by the PSA APIs for the PSA core mutexes: - mbedtls_threading_key_slot_mutex - mbedtls_threading_psa_globaldata_mutex - mbedtls_threading_psa_rngdata_mutex This means that even when the CC3XX legacy/PSA driver is not used, as long as the CC3XX platform is enabled the mutex handling will be provided by the CC3XX platform library. Since the CC3XX platform library provides the implementation and the threading_alt.h provides the definitions for the mutexes it makes sense to be in one place. This commit moves the threading_alt.h to the platform folder so that it can be included by applications which don't use the CC3XX mbedcrypto driver but they use Oberon PSA driver. Ref: NCSDK-31155 Signed-off-by: Georgios Vasilakis <[email protected]>
Vge0rge
force-pushed
the
cc3xx_mutex_fix
branch
from
b5f6fc0 to
a177abb
Compare
frkv
approved these changes
Jan 14, 2025
Contributor
frkv
left a comment
frkv
left a comment
There was a problem hiding this comment.
LGTM
This is one of the few files in Mbed TLS that don't require scoping (mbedtls/ psa/) so the movement shouldn't be any problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CC3XX platform contains the functions for mbedtls mutex handling:
These functions are not only used by the legacy mbedTLS APIs. They are also used by the PSA APIs for the PSA core mutexes:
This means that even when the CC3XX legacy/PSA driver is not used, as long as the CC3XX platform is enabled the mutex handling will be provided by the CC3XX platform library. Since the CC3XX platform library provides the implementation and the threading_alt.h provides the definitions for the mutexes it makes sense to be in one place.
This commit moves the threading_alt.h to the platform folder so that it can be included by applications which don't use the CC3XX mbedcrypto driver but they use Oberon PSA driver.
Ref: NCSDK-31155