Skip to content

Conversation

@NordicBuilder
Copy link
Contributor

This PR updates revision of the nrf_802154 component to commit
d37b238526ceaa99e94e197327ccb043e1316c40 of the sdk-nrf-802154
repository.

This commit updates revision of the nrf_802154 component.

Signed-off-by: Dawid Przybylo <[email protected]>
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the nrf_802154 component to a new revision, incorporating an additional alternate short address mechanism. Key changes include:

  • Adding new serialization routines for decoding and dispatching an alternate short address.
  • Extending the PIB API and internal data structures to support alternate short addresses.
  • Propagating the new alternate short address functionality throughout serialization, PIB, and filtering modules.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
nrf_802154/serialization/src/nrf_802154_spinel_dec_net.c Adds a new spinel decoder for alternate short address set
nrf_802154/serialization/src/nrf_802154_spinel_app.c Introduces alternate short address command in the app layer
nrf_802154/serialization/src/include/nrf_802154_spinel_datatypes.h Declares new spinel property and datatype for alternate address
nrf_802154/driver/src/nrf_802154_pib.h & nrf_802154/driver/src/nrf_802154_pib.c Updates PIB structures and API for alternate short address
nrf_802154/driver/src/nrf_802154.c Adds wrapper function for alternate short address set
nrf_802154/driver/src/mac_features/nrf_802154_filter.c Adjusts destination address checking to consider alternates
nrf_802154/common/include/nrf_802154.h Documents the alternate short address API
Files not reviewed (1)
  • nrf_802154/doc/CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (1)

nrf_802154/serialization/src/nrf_802154_spinel_app.c:667

  • When data_valid is false, assigning an invalid address (0xff, 0xff) instead of NULL may not clear the alternate short address as documented. Consider using NULL to trigger clearing of the alternate address.
if (!data_valid) { p_short_address = invalid_addr; }

@rlubos rlubos merged commit eccb4ab into nrfconnect:main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants