-
Notifications
You must be signed in to change notification settings - Fork 342
nfc: align the T2T and T4T Kconfig options with DTS node status #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nfc: align the T2T and T4T Kconfig options with DTS node status #1765
Conversation
bef2ac4 to
a4cf776
Compare
|
Thanks for providing this PR! We still haven't managed to resolve it. Just a though from me - how about moving the dependency to the CONFIG_NFC_PLATFORM option in sdk-nrf? Both T2T and T4T require some platform implementation for the runtime environment they are used in. Like that we'd avoid dependency expansion in the nrfxlib, which in theory could be used outside of nrf-sdk. |
I wanted to put this https://github.com/nrfconnect/sdk-nrf/blob/main/subsys/nfc/lib/Kconfig However, the current KConfig definition is written in such a way that it will fail silently for the user: If you were to add If you want to set it up like this, I can do that. The most important thing is that the build process for a project will fail with either approach. Also, there is nothing stopping us from moving the NFC T2T/T4T library Kconfig to sdk-nrf. You can follow the approach used by the SDC team for the SDC library. |
I see, I didn't take this into account. NFC configurations need some general refactoring, we'll do this at some point, when there is capacity. For now, your approach looks good. |
Aligned the availability of the NFC_T2T_NRFXLIB and NFC_T4T_NRFXLIB Kconfig options with the status of the nfct DTS node. Signed-off-by: Kamil Piszczek <[email protected]>
a4cf776 to
4b761f6
Compare
|
Pure rebase. The PR file diff has not changed |
Aligned the availability of the NFC_T2T_NRFXLIB and NFC_T4T_NRFXLIB Kconfig options with the status of the nfct DTS node.