Skip to content

nrf_rpc: fix initialization corner case #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

nrf_rpc: fix initialization corner case #1883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions nrf_rpc/nrf_rpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,18 +426,6 @@ static int transport_init(nrf_rpc_tr_receive_handler_t receive_cb)
const struct nrf_rpc_tr *transport = group->transport;
struct nrf_rpc_group_data *data = group->data;

NRF_RPC_ASSERT(transport != NULL);

/* Initialize all dependencies of `receive_handler` before calling the transport
* init to avoid possible data race if `receive_handler` was invoked before this
* function was completed. */
if (auto_free_rx_buf(transport)) {
err = nrf_rpc_os_event_init(&data->decode_done_event);
if (err < 0) {
continue;
}
}

err = transport->api->init(transport, receive_cb, NULL);
if (err) {
NRF_RPC_ERR("Failed to initialize transport, err: %d", err);
Expand Down Expand Up @@ -1138,6 +1126,7 @@ int nrf_rpc_init(nrf_rpc_err_handler_t err_handler)
for (NRF_RPC_AUTO_ARR_FOR(iter, group, &nrf_rpc_groups_array,
const struct nrf_rpc_group)) {
struct nrf_rpc_group_data *data = group->data;
const struct nrf_rpc_tr *transport = group->transport;

if (group_id >= 0xFF) {
return -NRF_ENOMEM;
Expand All @@ -1149,6 +1138,18 @@ int nrf_rpc_init(nrf_rpc_err_handler_t err_handler)
if (group->flags & NRF_RPC_FLAGS_WAIT_ON_INIT) {
wait_count++;
}

NRF_RPC_ASSERT(transport != NULL);

/* Initialize all groups' members before starting transports to avoid the risk of
* receiving a packet for a group that hasn't been initialized yet in case a single
* transport is used across multiple groups. */
if (auto_free_rx_buf(transport)) {
err = nrf_rpc_os_event_init(&data->decode_done_event);
if (err < 0) {
return err;
}
}
}

group_count = group_id;
Expand Down