nrf_rpc: Reset decode_done_event so event_wait always works#2159
Open
inductivekickback wants to merge 1 commit into
Open
nrf_rpc: Reset decode_done_event so event_wait always works#2159inductivekickback wants to merge 1 commit into
inductivekickback wants to merge 1 commit into
Conversation
If the transport is auto_free_rx_buf then the receive_handler must not return until after the packet has been decoded. Without this patch some code path sets the decode_done_event without a corresponding nrf_rpc_os_event_wait (not necessarily a bug) and then the event_wait stops working as intended. Signed-off-by: Daniel Veilleux <daniel.veilleux@nordicsemi.no>
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the transport is auto_free_rx_buf then the receive_handler must not return until after the packet has been decoded. Without this patch some code path sets the decode_done_event without a corresponding nrf_rpc_os_event_wait (not necessarily a bug) and then the event_wait stops working as intended.
Depends on nrfconnect/sdk-nrf/pull/29541