Skip to content
Back to pull request #3343

dts: bindings: comparator: nordic: Change ext analog inputs type to int #12485

Sign in to view logs

dts: bindings: comparator: nordic: Change ext analog inputs type to int

dts: bindings: comparator: nordic: Change ext analog inputs type to int #12485

Triggered via pull request October 13, 2025 10:15
@jaz1-nordicjaz1-nordic
synchronize #3343
jaz1-nordic:nrfx-7710_unify_analog_pins_defs
Status Success
Total duration 3m 7s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
3m 4s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 10 notices
Run compliance checks on patch series (PR): ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -BUILD_ASSERT((NRF_COMP_AIN0 == NRF_COMP_INPUT_0) && - (NRF_COMP_AIN1 == NRF_COMP_INPUT_1) && - (NRF_COMP_AIN2 == NRF_COMP_INPUT_2) && - (NRF_COMP_AIN3 == NRF_COMP_INPUT_3) && +BUILD_ASSERT((NRF_COMP_AIN0 == NRF_COMP_INPUT_0) && (NRF_COMP_AIN1 == NRF_COMP_INPUT_1) && + (NRF_COMP_AIN2 == NRF_COMP_INPUT_2) && (NRF_COMP_AIN3 == NRF_COMP_INPUT_3) && #if defined(COMP_PSEL_PSEL_AnalogInput4) - (NRF_COMP_AIN4 == NRF_COMP_INPUT_4) && + (NRF_COMP_AIN4 == NRF_COMP_INPUT_4) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput5) - (NRF_COMP_AIN5 == NRF_COMP_INPUT_5) && + (NRF_COMP_AIN5 == NRF_COMP_INPUT_5) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput6) - (NRF_COMP_AIN6 == NRF_COMP_INPUT_6) && + (NRF_COMP_AIN6 == NRF_COMP_INPUT_6) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput7) - (NRF_COMP_AIN7 == NRF_COMP_INPUT_7) && -#endif - (NRF_COMP_AIN0 == NRF_COMP_EXT_REF_0) && - (NRF_COMP_AIN1 == NRF_COMP_EXT_REF_1) && - (NRF_COMP_AIN2 == NRF_COMP_EXT_REF_2) && - (NRF_COMP_AIN3 == NRF_COMP_EXT_REF_3) && + (NRF_COMP_AIN7 == NRF_COMP_INPUT_7) && +#endif + (NRF_COMP_AIN0 == NRF_COMP_EXT_REF_0) && + (NRF_COMP_AIN1 == NRF_COMP_EXT_REF_1) && + (NRF_COMP_AIN2 == NRF_COMP_EXT_REF_2) && + (NRF_COMP_AIN3 == NRF_COMP_EXT_REF_3) && #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference4) - (NRF_COMP_AIN4 == NRF_COMP_EXT_REF_4) && + (NRF_COMP_AIN4 == NRF_COMP_EXT_REF_4) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference5) - (NRF_COMP_AIN5 == NRF_COMP_EXT_REF_5) && + (NRF_COMP_AIN5 == NRF_COMP_EXT_REF_5) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference6) - (NRF_COMP_AIN6 == NRF_COMP_EXT_REF_6) && + (NRF_COMP_AIN6 == NRF_COMP_EXT_REF_6) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference7) - (NRF_COMP_AIN7 == NRF_COMP_EXT_REF_7) && + (NRF_COMP_AIN7 == NRF_COMP_EXT_REF_7) && #endif #if defined(COMP_PSEL_PSEL_VddDiv2) - (NRF_COMP_VDD_DIV2 == NRF_COMP_VDD_DIV2) && + (NRF_COMP_VDD_DIV2 == NRF_COMP_VDD_DIV2) && #endif #if defined(COMP_PSEL_PSEL_VddhDiv5) - (NRF_COMP_VDDH_DIV5 == NRF_COMP_VDDH_DIV5) && -#endif - 1, + (NRF_COMP_VDDH_DIV5 == NRF_COMP_VDDH_DIV5) && +#endif + 1, File:drivers/comparator/comparator_nrf_comp.c Line:117 You may want to run clang-format on this change: -static int shim_nrf_comp_psel_to_nrf(uint8_t shim, - nrf_comp_input_t *nrf) +static int shim_nrf_comp_psel_to_nrf(uint8_t shim, nrf_comp_input_t *nrf) File:drivers/comparator/comparator_nrf_comp.c Line:246 You may want to run clang-format on this change: -static int shim_nrf_comp_psel_to_nrf(uint8_t shim, - nrf_comp_input_t *nrf) +static int shim_nrf_comp_psel_to_nrf(uint8_t shim, nrf_comp_input_t *nrf) File:drivers/comparator/comparator_nrf_comp.c Line:257 You may want to run clang-format on this change: -static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, - nrf_comp_ext_ref_t *nrf) +static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, nrf_comp_ext_ref_t *nrf) File:drivers/comparator/comparator_nrf_comp.c Line:382 You may want to run clang-format on this change: -static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, - nrf_comp_ext_ref_t *nrf) +static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, nrf_comp_ext_ref_t *nrf) File:drivers/comparator/comparator_nrf_comp.c Line:393 You may want to run clang-format on this change: -BUILD_ASSERT((NRF_COMP_AIN0 == NRF_LPCOMP_INPUT_0) && - (NRF_COMP_AIN1 == NRF_LPCOMP_INPUT_1) && - (NRF_COMP_AIN2 == NRF_LPCOMP_INPUT_2) && - (NRF_COMP_AIN3 == NRF_LPCOMP_INPUT_3) && - (NRF_COMP_AIN4 == NRF_LPCOMP_INPUT_4) && - (NRF_COMP_AIN5 == NRF_LPCOMP_INPUT_5) && - (NRF_COMP_AIN6 == NRF_LPCOMP_INPUT_6) && - (NRF_COMP_AIN7 == NRF_LPCOMP_INPUT_7) && - (NRF_COMP_AIN0 == NRF_LPCOMP_EXT_REF
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L213
drivers/comparator/comparator_nrf_lpcomp.c:213 -static int shim_nrf_lpcomp_extrefsel_to_nrf(uint8_t shim, - nrf_lpcomp_ext_ref_t *nrf) +static int shim_nrf_lpcomp_extrefsel_to_nrf(uint8_t shim, nrf_lpcomp_ext_ref_t *nrf) { switch (shim) { - case NRF_COMP_AIN0: + case NRF_COMP_AIN0: *nrf = NRF_LPCOMP_EXT_REF_REF0; break; - case NRF_COMP_AIN1: + case NRF_COMP_AIN1:
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L195
drivers/comparator/comparator_nrf_lpcomp.c:195 -static int shim_nrf_lpcomp_extrefsel_to_nrf(uint8_t shim, - nrf_lpcomp_ext_ref_t *nrf) +static int shim_nrf_lpcomp_extrefsel_to_nrf(uint8_t shim, nrf_lpcomp_ext_ref_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L181
drivers/comparator/comparator_nrf_lpcomp.c:181 -static int shim_nrf_lpcomp_psel_to_nrf(uint8_t shim, - nrf_lpcomp_input_t *nrf) +static int shim_nrf_lpcomp_psel_to_nrf(uint8_t shim, nrf_lpcomp_input_t *nrf) { switch (shim) { - case NRF_COMP_AIN0: + case NRF_COMP_AIN0: *nrf = NRF_LPCOMP_INPUT_0; break; - case NRF_COMP_AIN1: + case NRF_COMP_AIN1: *nrf = NRF_LPCOMP_INPUT_1; break; - case NRF_COMP_AIN2: + case NRF_COMP_AIN2: *nrf = NRF_LPCOMP_INPUT_2; break; - case NRF_COMP_AIN3: + case NRF_COMP_AIN3: *nrf = NRF_LPCOMP_INPUT_3; break; - case NRF_COMP_AIN4: + case NRF_COMP_AIN4: *nrf = NRF_LPCOMP_INPUT_4; break; - case NRF_COMP_AIN5: + case NRF_COMP_AIN5: *nrf = NRF_LPCOMP_INPUT_5; break; - case NRF_COMP_AIN6: + case NRF_COMP_AIN6: *nrf = NRF_LPCOMP_INPUT_6; break; - case NRF_COMP_AIN7: + case NRF_COMP_AIN7:
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L139
drivers/comparator/comparator_nrf_lpcomp.c:139 -static int shim_nrf_lpcomp_psel_to_nrf(uint8_t shim, - nrf_lpcomp_input_t *nrf) +static int shim_nrf_lpcomp_psel_to_nrf(uint8_t shim, nrf_lpcomp_input_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L54
drivers/comparator/comparator_nrf_lpcomp.c:54 -BUILD_ASSERT((NRF_COMP_AIN0 == NRF_LPCOMP_INPUT_0) && - (NRF_COMP_AIN1 == NRF_LPCOMP_INPUT_1) && - (NRF_COMP_AIN2 == NRF_LPCOMP_INPUT_2) && - (NRF_COMP_AIN3 == NRF_LPCOMP_INPUT_3) && - (NRF_COMP_AIN4 == NRF_LPCOMP_INPUT_4) && - (NRF_COMP_AIN5 == NRF_LPCOMP_INPUT_5) && - (NRF_COMP_AIN6 == NRF_LPCOMP_INPUT_6) && - (NRF_COMP_AIN7 == NRF_LPCOMP_INPUT_7) && - (NRF_COMP_AIN0 == NRF_LPCOMP_EXT_REF_REF0) && - (NRF_COMP_AIN1 == NRF_LPCOMP_EXT_REF_REF1), +BUILD_ASSERT((NRF_COMP_AIN0 == NRF_LPCOMP_INPUT_0) && (NRF_COMP_AIN1 == NRF_LPCOMP_INPUT_1) && + (NRF_COMP_AIN2 == NRF_LPCOMP_INPUT_2) && + (NRF_COMP_AIN3 == NRF_LPCOMP_INPUT_3) && + (NRF_COMP_AIN4 == NRF_LPCOMP_INPUT_4) && + (NRF_COMP_AIN5 == NRF_LPCOMP_INPUT_5) && + (NRF_COMP_AIN6 == NRF_LPCOMP_INPUT_6) && + (NRF_COMP_AIN7 == NRF_LPCOMP_INPUT_7) && + (NRF_COMP_AIN0 == NRF_LPCOMP_EXT_REF_REF0) && + (NRF_COMP_AIN1 == NRF_LPCOMP_EXT_REF_REF1),
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L393
drivers/comparator/comparator_nrf_comp.c:393 -static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, - nrf_comp_ext_ref_t *nrf) +static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, nrf_comp_ext_ref_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L382
drivers/comparator/comparator_nrf_comp.c:382 -static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, - nrf_comp_ext_ref_t *nrf) +static int shim_nrf_comp_extrefsel_to_nrf(uint8_t shim, nrf_comp_ext_ref_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L257
drivers/comparator/comparator_nrf_comp.c:257 -static int shim_nrf_comp_psel_to_nrf(uint8_t shim, - nrf_comp_input_t *nrf) +static int shim_nrf_comp_psel_to_nrf(uint8_t shim, nrf_comp_input_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L246
drivers/comparator/comparator_nrf_comp.c:246 -static int shim_nrf_comp_psel_to_nrf(uint8_t shim, - nrf_comp_input_t *nrf) +static int shim_nrf_comp_psel_to_nrf(uint8_t shim, nrf_comp_input_t *nrf)
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L117
drivers/comparator/comparator_nrf_comp.c:117 -BUILD_ASSERT((NRF_COMP_AIN0 == NRF_COMP_INPUT_0) && - (NRF_COMP_AIN1 == NRF_COMP_INPUT_1) && - (NRF_COMP_AIN2 == NRF_COMP_INPUT_2) && - (NRF_COMP_AIN3 == NRF_COMP_INPUT_3) && +BUILD_ASSERT((NRF_COMP_AIN0 == NRF_COMP_INPUT_0) && (NRF_COMP_AIN1 == NRF_COMP_INPUT_1) && + (NRF_COMP_AIN2 == NRF_COMP_INPUT_2) && (NRF_COMP_AIN3 == NRF_COMP_INPUT_3) && #if defined(COMP_PSEL_PSEL_AnalogInput4) - (NRF_COMP_AIN4 == NRF_COMP_INPUT_4) && + (NRF_COMP_AIN4 == NRF_COMP_INPUT_4) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput5) - (NRF_COMP_AIN5 == NRF_COMP_INPUT_5) && + (NRF_COMP_AIN5 == NRF_COMP_INPUT_5) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput6) - (NRF_COMP_AIN6 == NRF_COMP_INPUT_6) && + (NRF_COMP_AIN6 == NRF_COMP_INPUT_6) && #endif #if defined(COMP_PSEL_PSEL_AnalogInput7) - (NRF_COMP_AIN7 == NRF_COMP_INPUT_7) && -#endif - (NRF_COMP_AIN0 == NRF_COMP_EXT_REF_0) && - (NRF_COMP_AIN1 == NRF_COMP_EXT_REF_1) && - (NRF_COMP_AIN2 == NRF_COMP_EXT_REF_2) && - (NRF_COMP_AIN3 == NRF_COMP_EXT_REF_3) && + (NRF_COMP_AIN7 == NRF_COMP_INPUT_7) && +#endif + (NRF_COMP_AIN0 == NRF_COMP_EXT_REF_0) && + (NRF_COMP_AIN1 == NRF_COMP_EXT_REF_1) && + (NRF_COMP_AIN2 == NRF_COMP_EXT_REF_2) && + (NRF_COMP_AIN3 == NRF_COMP_EXT_REF_3) && #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference4) - (NRF_COMP_AIN4 == NRF_COMP_EXT_REF_4) && + (NRF_COMP_AIN4 == NRF_COMP_EXT_REF_4) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference5) - (NRF_COMP_AIN5 == NRF_COMP_EXT_REF_5) && + (NRF_COMP_AIN5 == NRF_COMP_EXT_REF_5) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference6) - (NRF_COMP_AIN6 == NRF_COMP_EXT_REF_6) && + (NRF_COMP_AIN6 == NRF_COMP_EXT_REF_6) && #endif #if defined(COMP_EXTREFSEL_EXTREFSEL_AnalogReference7) - (NRF_COMP_AIN7 == NRF_COMP_EXT_REF_7) && + (NRF_COMP_AIN7 == NRF_COMP_EXT_REF_7) && #endif #if defined(COMP_PSEL_PSEL_VddDiv2) - (NRF_COMP_VDD_DIV2 == NRF_COMP_VDD_DIV2) && + (NRF_COMP_VDD_DIV2 == NRF_COMP_VDD_DIV2) && #endif #if defined(COMP_PSEL_PSEL_VddhDiv5) - (NRF_COMP_VDDH_DIV5 == NRF_COMP_VDDH_DIV5) && -#endif - 1, + (NRF_COMP_VDDH_DIV5 == NRF_COMP_VDDH_DIV5) && +#endif + 1,

Artifacts

Produced during runtime
Name Size Digest
compliance.xml
1.66 KB
sha256:4bac38a4a49a5a27c35c012d6578005d3132d375c1b411fc1b2b01689c118b20