Skip to content
Back to pull request #3384

drivers: adc: nrfx_saadc: Remove platform dependencies #12505

Sign in to view logs

drivers: adc: nrfx_saadc: Remove platform dependencies

drivers: adc: nrfx_saadc: Remove platform dependencies #12505

Triggered via pull request October 13, 2025 12:29
@jaz1-nordicjaz1-nordic
synchronize #3384
jaz1-nordic:nrfx-7708_pin_translation_to_driver
Status Success
Total duration 2m 39s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 35s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 8 notices
Run compliance checks on patch series (PR): ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && + (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && + (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && + (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && + (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && + (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && #if defined(SAADC_CH_PSELP_PSELP_VDDHDIV5) - (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && + (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && #endif #if defined(SAADC_CH_PSELP_PSELP_VDD) - (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) && -#endif - 1, + (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) && +#endif + 1, File:drivers/adc/adc_nrfx_saadc.c Line:34 You may want to run clang-format on this change: - .channel_config = { + .channel_config = + { #if NRF_SAADC_HAS_CH_CONFIG_RES - .resistor_p = NRF_SAADC_RESISTOR_DISABLED, - .resistor_n = NRF_SAADC_RESISTOR_DISABLED, + .resistor_p = NRF_SAADC_RESISTOR_DISABLED, + .resistor_n = NRF_SAADC_RESISTOR_DISABLED, #endif #if NRF_SAADC_HAS_CH_BURST - .burst = NRF_SAADC_BURST_DISABLED, -#endif - }, + .burst = NRF_SAADC_BURST_DISABLED, +#endif + }, File:drivers/adc/adc_nrfx_saadc.c Line:224 You may want to run clang-format on this change: - .read = adc_nrfx_read, + .read = adc_nrfx_read, #ifdef CONFIG_ADC_ASYNC - .read_async = adc_nrfx_read_async, -#endif - .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE, + .read_async = adc_nrfx_read_async, +#endif + .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE, File:drivers/adc/adc_nrfx_saadc.c Line:696 You may want to run clang-format on this change: - (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && + (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && + (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && + (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && + (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && + (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && #if defined(COMP_PSEL_PSEL_VddhDiv5) - (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && + (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && #endif #if defined(COMP_PSEL_PSEL_VddDiv2) - (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) && -#endif - 1, + (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) && +#endif + 1, File:drivers/comparator/comparator_nrf_comp.c Line:88 You may want to run clang-format on this change: - (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7), + (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_COMP_AIN3 == NRFX_ANALOG_EXTE
You may want to run clang-format on this change: include/zephyr/dt-bindings/comparator/nrf-comp.h#L22
include/zephyr/dt-bindings/comparator/nrf-comp.h:22 -#define NRF_COMP_AIN_VDD_DIV2 (NRF_COMP_AIN_VDD_SHIM_OFFSET + 1) -#define NRF_COMP_AIN_VDDH_DIV5 (NRF_COMP_AIN_VDD_SHIM_OFFSET + 4) +#define NRF_COMP_AIN_VDD_DIV2 (NRF_COMP_AIN_VDD_SHIM_OFFSET + 1) +#define NRF_COMP_AIN_VDDH_DIV5 (NRF_COMP_AIN_VDD_SHIM_OFFSET + 4)
You may want to run clang-format on this change: include/zephyr/dt-bindings/adc/nrf-saadc.h#L65
include/zephyr/dt-bindings/adc/nrf-saadc.h:65 -#define NRF_SAADC_GND (NRF_SAADC_AIN_VDD_SHIM_OFFSET - 1) +#define NRF_SAADC_GND (NRF_SAADC_AIN_VDD_SHIM_OFFSET - 1) #define NRF_SAADC_AIN_VDD_SHIM_OFFSET 128 -#define NRF_SAADC_VDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 0) -#define NRF_SAADC_VDDDIV2 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 1) -#define NRF_SAADC_AVDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 2) -#define NRF_SAADC_DVDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 3) -#define NRF_SAADC_VDDHDIV5 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 4) -#define NRF_SAADC_VDDL (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 5) -#define NRF_SAADC_DECB (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 6) -#define NRF_SAADC_VSS (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 7) -#define NRF_SAADC_VDDAO3V0 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 8) -#define NRF_SAADC_VDDAO1V8 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 9) -#define NRF_SAADC_VDDAO0V8 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 10) -#define NRF_SAADC_VDDRF (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 11) -#define NRF_SAADC_VBAT (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 12) -#define NRF_SAADC_AIN_DISABLED 255 /* UINT8_MAX */ +#define NRF_SAADC_VDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 0) +#define NRF_SAADC_VDDDIV2 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 1) +#define NRF_SAADC_AVDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 2) +#define NRF_SAADC_DVDD (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 3) +#define NRF_SAADC_VDDHDIV5 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 4) +#define NRF_SAADC_VDDL (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 5) +#define NRF_SAADC_DECB (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 6) +#define NRF_SAADC_VSS (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 7) +#define NRF_SAADC_VDDAO3V0 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 8) +#define NRF_SAADC_VDDAO1V8 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 9) +#define NRF_SAADC_VDDAO0V8 (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 10) +#define NRF_SAADC_VDDRF (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 11) +#define NRF_SAADC_VBAT (NRF_SAADC_AIN_VDD_SHIM_OFFSET + 12) +#define NRF_SAADC_AIN_DISABLED 255 /* UINT8_MAX */
You may want to run clang-format on this change: include/zephyr/dt-bindings/adc/nrf-saadc.h#L20
include/zephyr/dt-bindings/adc/nrf-saadc.h:20 -#define NRF_SAADC_AIN0 0 -#define NRF_SAADC_AIN1 1 -#define NRF_SAADC_AIN2 2 -#define NRF_SAADC_AIN3 3 -#define NRF_SAADC_AIN4 4 -#define NRF_SAADC_AIN5 5 -#define NRF_SAADC_AIN6 6 -#define NRF_SAADC_AIN7 7 -#define NRF_SAADC_AIN8 8 -#define NRF_SAADC_AIN9 9 +#define NRF_SAADC_AIN0 0 +#define NRF_SAADC_AIN1 1 +#define NRF_SAADC_AIN2 2 +#define NRF_SAADC_AIN3 3 +#define NRF_SAADC_AIN4 4 +#define NRF_SAADC_AIN5 5 +#define NRF_SAADC_AIN6 6 +#define NRF_SAADC_AIN7 7 +#define NRF_SAADC_AIN8 8 +#define NRF_SAADC_AIN9 9
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_lpcomp.c#L47
drivers/comparator/comparator_nrf_lpcomp.c:47 - (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7), + (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && + (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && + (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && + (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && + (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7),
You may want to run clang-format on this change: drivers/comparator/comparator_nrf_comp.c#L88
drivers/comparator/comparator_nrf_comp.c:88 - (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && + (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && + (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && + (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && + (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && + (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && #if defined(COMP_PSEL_PSEL_VddhDiv5) - (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && + (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && #endif #if defined(COMP_PSEL_PSEL_VddDiv2) - (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) && -#endif - 1, + (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) && +#endif + 1,
You may want to run clang-format on this change: drivers/adc/adc_nrfx_saadc.c#L696
drivers/adc/adc_nrfx_saadc.c:696 - .read = adc_nrfx_read, + .read = adc_nrfx_read, #ifdef CONFIG_ADC_ASYNC - .read_async = adc_nrfx_read_async, -#endif - .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE, + .read_async = adc_nrfx_read_async, +#endif + .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE,
You may want to run clang-format on this change: drivers/adc/adc_nrfx_saadc.c#L224
drivers/adc/adc_nrfx_saadc.c:224 - .channel_config = { + .channel_config = + { #if NRF_SAADC_HAS_CH_CONFIG_RES - .resistor_p = NRF_SAADC_RESISTOR_DISABLED, - .resistor_n = NRF_SAADC_RESISTOR_DISABLED, + .resistor_p = NRF_SAADC_RESISTOR_DISABLED, + .resistor_n = NRF_SAADC_RESISTOR_DISABLED, #endif #if NRF_SAADC_HAS_CH_BURST - .burst = NRF_SAADC_BURST_DISABLED, -#endif - }, + .burst = NRF_SAADC_BURST_DISABLED, +#endif + },
You may want to run clang-format on this change: drivers/adc/adc_nrfx_saadc.c#L34
drivers/adc/adc_nrfx_saadc.c:34 - (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && - (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && - (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && - (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && - (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && - (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && - (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && + (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) && + (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) && + (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) && + (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) && + (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) && + (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) && + (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) && #if defined(SAADC_CH_PSELP_PSELP_VDDHDIV5) - (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && + (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) && #endif #if defined(SAADC_CH_PSELP_PSELP_VDD) - (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) && -#endif - 1, + (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) && +#endif + 1,

Artifacts

Produced during runtime
Name Size Digest
compliance.xml
1.75 KB
sha256:fc185f9fee502845dc41493e24cea42902d872dec27eba2f7bba658752c46540