merge collab-nrfx-4.0 to main branch #12984
compliance.yml
on: pull_request
Run compliance checks on patch series (PR)
3m 7s
Annotations
10 errors, 11 warnings, and 10 notices
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
Identity.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
df3766a97b8f52b769beae33e12f3855f960eadc: Signed-off-by line (Signed-off-by: Krzysztof Chruściński <[email protected]>) does not follow the syntax: First Last <email>.
|
|
Run compliance checks on patch series (PR):
Checkpatch.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
C99_COMMENTS: do not use C99 // comments
File:drivers/display/display_nrf_led_matrix.c
Line:537
POINTER_LOCATION: "foo * bar" should be "foo *bar"
File:drivers/gpio/gpio_nrfx.c
Line:68
LONG_LINE: line length of 105 exceeds 100 columns
File:drivers/i2c/i2c_nrfx_twim_common.h
Line:46
LONG_LINE: line length of 105 exceeds 100 columns
File:drivers/i2c/i2c_nrfx_twim_common.h
Line:47
LONG_LINE: line length of 108 exceeds 100 columns
File:drivers/i2c/i2c_nrfx_twim_rtio.c
Line:223
LONG_LINE: line length of 108 exceeds 100 columns
File:drivers/i2c/i2c_nrfx_twim_rtio.c
Line:226
LONG_LINE: line length of 115 exceeds 100 columns
File:drivers/i2c/i2c_nrfx_twim_rtio.c
Line:290
SPACING: space prohibited before that close parenthesis ')'
File:drivers/i2c/i2c_nrfx_twis.c
Line:337
BLOCK_COMMENT_STYLE: Block comments should align the * on each line
File:drivers/i2s/i2s_nrfx.c
Line:72
POINTER_LOCATION: "foo * bar" should be "foo *bar"
File:drivers/pwm/pwm_nrf_sw.c
Line:66
POINTER_LOCATION: "foo * bar" should be "foo *bar"
File:include/zephyr/drivers/gpio/gpio_nrf.h
Line:21
MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
File:modules/hal_nordic/nrfx/nrfx_glue.c
Line:51
OPEN_BRACE: that open brace { should be on the previous line
File:modules/hal_nordic/nrfx/nrfx_glue.c
Line:52
LEADING_SPACE: please, no spaces at the start of a line
File:soc/nordic/common/gpiote_nrfx.c
Line:11
LEADING_SPACE: please, no spaces at the start of a line
File:soc/nordic/common/gpiote_nrfx.c
Line:13
LEADING_SPACE: please, no spaces at the start of a line
File:soc/nordic/common/gpiote_nrfx.h
Line:16
LEADING_SPACE: please, no spaces at the start of a line
File:soc/nordic/common/gpiote_nrfx.h
Line:18
|
|
Run compliance checks on patch series (PR)
Process completed with exit code 2.
|
|
OPEN_BRACE:
modules/hal_nordic/nrfx/nrfx_glue.c#L52
modules/hal_nordic/nrfx/nrfx_glue.c:52 that open brace { should be on the previous line
|
|
POINTER_LOCATION:
include/zephyr/drivers/gpio/gpio_nrf.h#L21
include/zephyr/drivers/gpio/gpio_nrf.h:21 "foo * bar" should be "foo *bar"
|
|
POINTER_LOCATION:
drivers/pwm/pwm_nrf_sw.c#L66
drivers/pwm/pwm_nrf_sw.c:66 "foo * bar" should be "foo *bar"
|
|
SPACING:
drivers/i2c/i2c_nrfx_twis.c#L337
drivers/i2c/i2c_nrfx_twis.c:337 space prohibited before that close parenthesis ')'
|
|
POINTER_LOCATION:
drivers/gpio/gpio_nrfx.c#L68
drivers/gpio/gpio_nrfx.c:68 "foo * bar" should be "foo *bar"
|
|
C99_COMMENTS:
drivers/display/display_nrf_led_matrix.c#L537
drivers/display/display_nrf_led_matrix.c:537 do not use C99 // comments
|
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
- (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
- (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
- (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
- (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
- (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
- (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
+ (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
+ (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
+ (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
+ (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
+ (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
+ (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
+ (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
#if NRF_SAADC_HAS_INPUT_VDDHDIV5
- (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
+ (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
#endif
#if NRF_SAADC_HAS_INPUT_VDD
- (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) &&
-#endif
- 1,
+ (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) &&
+#endif
+ 1,
File:drivers/adc/adc_nrfx_saadc.c
Line:38
You may want to run clang-format on this change:
- .channel_config = {
+ .channel_config =
+ {
#if NRF_SAADC_HAS_CH_CONFIG_RES
- .resistor_p = NRF_SAADC_RESISTOR_DISABLED,
- .resistor_n = NRF_SAADC_RESISTOR_DISABLED,
+ .resistor_p = NRF_SAADC_RESISTOR_DISABLED,
+ .resistor_n = NRF_SAADC_RESISTOR_DISABLED,
#endif
#if NRF_SAADC_HAS_CH_BURST
- .burst = NRF_SAADC_BURST_DISABLED,
-#endif
- },
+ .burst = NRF_SAADC_BURST_DISABLED,
+#endif
+ },
File:drivers/adc/adc_nrfx_saadc.c
Line:228
You may want to run clang-format on this change:
- ? (1 + sequence->options->extra_samplings)
- : active_channel_cnt));
+ ? (1 + sequence->options->extra_samplings)
+ : active_channel_cnt));
File:drivers/adc/adc_nrfx_saadc.c
Line:601
You may want to run clang-format on this change:
- .read = adc_nrfx_read,
+ .read = adc_nrfx_read,
#ifdef CONFIG_ADC_ASYNC
- .read_async = adc_nrfx_read_async,
-#endif
- .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE,
+ .read_async = adc_nrfx_read_async,
+#endif
+ .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE,
File:drivers/adc/adc_nrfx_saadc.c
Line:713
You may want to run clang-format on this change:
- ? DMIC_NRFX_AUDIO_CLOCK_FREQ
- : DMIC_NRFX_CLOCK_FREQ,
+ ? DMIC_NRFX_AUDIO_CLOCK_FREQ
+ : DMIC_NRFX_CLOCK_FREQ,
.sampling_rate = config->streams[0].pcm_rate,
.output_freq_min = config->io.min_pdm_clk_freq,
- .output_freq_max = config->io.max_pdm_clk_freq
- };
+ .output_freq_max = config->io.max_pdm_clk_freq};
File:drivers/audio/dmic_nrfx_pdm.c
Line:300
You may want to run clang-format on this change:
- (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
- (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
- (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
- (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
- (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
- (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
- (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
+ (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
+ (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
+ (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
+ (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
+ (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
+ (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
+ (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
#if NRF_COMP_HAS_VDDH_DIV5
- (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
+ (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
#endif
#if NRF_COMP_HAS_VDD_DIV2
- (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) &&
-#endif
- 1,
+ (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNA
|
|
LEADING_SPACE:
soc/nordic/common/gpiote_nrfx.h#L16
soc/nordic/common/gpiote_nrfx.h:16 please, no spaces at the start of a line
|
|
LEADING_SPACE:
soc/nordic/common/gpiote_nrfx.c#L13
soc/nordic/common/gpiote_nrfx.c:13 please, no spaces at the start of a line
|
|
LEADING_SPACE:
soc/nordic/common/gpiote_nrfx.c#L11
soc/nordic/common/gpiote_nrfx.c:11 please, no spaces at the start of a line
|
|
MACRO_WITH_FLOW_CONTROL:
modules/hal_nordic/nrfx/nrfx_glue.c#L51
modules/hal_nordic/nrfx/nrfx_glue.c:51 Macros with flow control statements should be avoided
|
|
BLOCK_COMMENT_STYLE:
drivers/i2s/i2s_nrfx.c#L72
drivers/i2s/i2s_nrfx.c:72 Block comments should align the * on each line
|
|
LONG_LINE:
drivers/i2c/i2c_nrfx_twim_rtio.c#L290
drivers/i2c/i2c_nrfx_twim_rtio.c:290 line length of 115 exceeds 100 columns
|
|
LONG_LINE:
drivers/i2c/i2c_nrfx_twim_rtio.c#L226
drivers/i2c/i2c_nrfx_twim_rtio.c:226 line length of 108 exceeds 100 columns
|
|
LONG_LINE:
drivers/i2c/i2c_nrfx_twim_rtio.c#L223
drivers/i2c/i2c_nrfx_twim_rtio.c:223 line length of 108 exceeds 100 columns
|
|
LONG_LINE:
drivers/i2c/i2c_nrfx_twim_common.h#L47
drivers/i2c/i2c_nrfx_twim_common.h:47 line length of 105 exceeds 100 columns
|
|
LONG_LINE:
drivers/i2c/i2c_nrfx_twim_common.h#L46
drivers/i2c/i2c_nrfx_twim_common.h:46 line length of 105 exceeds 100 columns
|
|
You may want to run clang-format on this change:
drivers/display/display_nrf_led_matrix.c#L459
drivers/display/display_nrf_led_matrix.c:459
- nrf_timer_compare_event_get(1 + i)),
+ nrf_timer_compare_event_get(1 + i)),
nrf_gpiote_event_address_get(dev_config->gpiote->p_reg,
- nrf_gpiote_out_task_get(*gpiote_ch)),
+ nrf_gpiote_out_task_get(*gpiote_ch)),
|
|
You may want to run clang-format on this change:
drivers/comparator/comparator_nrf_lpcomp.c#L361
drivers/comparator/comparator_nrf_lpcomp.c:361
- if (nrfx_lpcomp_init(&shim_nrf_lpcomp_data0.config,
- shim_nrf_lpcomp_event_handler) != 0) {
+ if (nrfx_lpcomp_init(&shim_nrf_lpcomp_data0.config, shim_nrf_lpcomp_event_handler) != 0) {
|
|
You may want to run clang-format on this change:
drivers/comparator/comparator_nrf_lpcomp.c#L48
drivers/comparator/comparator_nrf_lpcomp.c:48
- (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
- (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
- (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
- (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
- (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
- (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
- (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7),
+ (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
+ (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
+ (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
+ (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
+ (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
+ (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
+ (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7),
|
|
You may want to run clang-format on this change:
drivers/comparator/comparator_nrf_comp.c#L214
drivers/comparator/comparator_nrf_comp.c:214
-static int shim_nrf_comp_isource_to_nrf(enum comp_nrf_comp_isource shim,
- nrf_comp_isource_t *nrf)
+static int shim_nrf_comp_isource_to_nrf(enum comp_nrf_comp_isource shim, nrf_comp_isource_t *nrf)
|
|
You may want to run clang-format on this change:
drivers/comparator/comparator_nrf_comp.c#L75
drivers/comparator/comparator_nrf_comp.c:75
- (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
- (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
- (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
- (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
- (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
- (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
- (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
+ (NRF_COMP_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
+ (NRF_COMP_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
+ (NRF_COMP_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
+ (NRF_COMP_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
+ (NRF_COMP_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
+ (NRF_COMP_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
+ (NRF_COMP_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
#if NRF_COMP_HAS_VDDH_DIV5
- (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
+ (NRF_COMP_AIN_VDDH_DIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
#endif
#if NRF_COMP_HAS_VDD_DIV2
- (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) &&
-#endif
- 1,
+ (NRF_COMP_AIN_VDD_DIV2 == NRFX_ANALOG_INTERNAL_VDDDIV2) &&
+#endif
+ 1,
|
|
You may want to run clang-format on this change:
drivers/audio/dmic_nrfx_pdm.c#L300
drivers/audio/dmic_nrfx_pdm.c:300
- ? DMIC_NRFX_AUDIO_CLOCK_FREQ
- : DMIC_NRFX_CLOCK_FREQ,
+ ? DMIC_NRFX_AUDIO_CLOCK_FREQ
+ : DMIC_NRFX_CLOCK_FREQ,
.sampling_rate = config->streams[0].pcm_rate,
.output_freq_min = config->io.min_pdm_clk_freq,
- .output_freq_max = config->io.max_pdm_clk_freq
- };
+ .output_freq_max = config->io.max_pdm_clk_freq};
|
|
You may want to run clang-format on this change:
drivers/adc/adc_nrfx_saadc.c#L713
drivers/adc/adc_nrfx_saadc.c:713
- .read = adc_nrfx_read,
+ .read = adc_nrfx_read,
#ifdef CONFIG_ADC_ASYNC
- .read_async = adc_nrfx_read_async,
-#endif
- .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE,
+ .read_async = adc_nrfx_read_async,
+#endif
+ .ref_internal = NRFX_SAADC_REF_INTERNAL_VALUE,
|
|
You may want to run clang-format on this change:
drivers/adc/adc_nrfx_saadc.c#L601
drivers/adc/adc_nrfx_saadc.c:601
- ? (1 + sequence->options->extra_samplings)
- : active_channel_cnt));
+ ? (1 + sequence->options->extra_samplings)
+ : active_channel_cnt));
|
|
You may want to run clang-format on this change:
drivers/adc/adc_nrfx_saadc.c#L228
drivers/adc/adc_nrfx_saadc.c:228
- .channel_config = {
+ .channel_config =
+ {
#if NRF_SAADC_HAS_CH_CONFIG_RES
- .resistor_p = NRF_SAADC_RESISTOR_DISABLED,
- .resistor_n = NRF_SAADC_RESISTOR_DISABLED,
+ .resistor_p = NRF_SAADC_RESISTOR_DISABLED,
+ .resistor_n = NRF_SAADC_RESISTOR_DISABLED,
#endif
#if NRF_SAADC_HAS_CH_BURST
- .burst = NRF_SAADC_BURST_DISABLED,
-#endif
- },
+ .burst = NRF_SAADC_BURST_DISABLED,
+#endif
+ },
|
|
You may want to run clang-format on this change:
drivers/adc/adc_nrfx_saadc.c#L38
drivers/adc/adc_nrfx_saadc.c:38
- (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
- (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
- (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
- (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
- (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
- (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
- (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
+ (NRF_SAADC_AIN1 == NRFX_ANALOG_EXTERNAL_AIN1) &&
+ (NRF_SAADC_AIN2 == NRFX_ANALOG_EXTERNAL_AIN2) &&
+ (NRF_SAADC_AIN3 == NRFX_ANALOG_EXTERNAL_AIN3) &&
+ (NRF_SAADC_AIN4 == NRFX_ANALOG_EXTERNAL_AIN4) &&
+ (NRF_SAADC_AIN5 == NRFX_ANALOG_EXTERNAL_AIN5) &&
+ (NRF_SAADC_AIN6 == NRFX_ANALOG_EXTERNAL_AIN6) &&
+ (NRF_SAADC_AIN7 == NRFX_ANALOG_EXTERNAL_AIN7) &&
#if NRF_SAADC_HAS_INPUT_VDDHDIV5
- (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
+ (NRF_SAADC_VDDHDIV5 == NRFX_ANALOG_INTERNAL_VDDHDIV5) &&
#endif
#if NRF_SAADC_HAS_INPUT_VDD
- (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) &&
-#endif
- 1,
+ (NRF_SAADC_VDD == NRFX_ANALOG_INTERNAL_VDD) &&
+#endif
+ 1,
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
compliance.xml
|
15.6 KB |
sha256:da36e02f0786d7a16e3c5921b7f7ee1014417231e1f02c793cdc69d94a49e9e6
|
|