-
Notifications
You must be signed in to change notification settings - Fork 716
[nrf fromlist] boards: nordic: Add initial support for nRF54LM20A/ns #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c349175
to
eb4aa99
Compare
|
|
||
#ifdef USE_NON_SECURE_ADDRESS_MAP | ||
global_peripherals: peripheral@40000000 { | ||
#address-cells = <1>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are missing reg properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe provide the feedback on the upstream PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what you mean/what they are supposed to be. I copied these from l15 any they don't have any reg either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/zephyrproject-rtos/zephyr/pull/93098/files (which is being blocked for unrelated issues)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
eb4aa99
to
28abec4
Compare
|
||
sram0_s: image_s@20000000 { | ||
/* Secure image memory */ | ||
reg = <0x20000000 DT_SIZE_K(256)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment before says that this should be 208 actually, which one is correct?
*/ | ||
slot0_partition: partition@0 { | ||
label = "image-0"; | ||
reg = <0x0000000 DT_SIZE_K(512)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both this number and the ns partition does not match the comment, please update accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already commented on/fixed upstream, better comment on the upstream PR than this which is just a fromlist.
0fd35ab
to
96072bb
Compare
34bda7a
to
52d4183
Compare
Rebase |
52d4183
to
fa9881b
Compare
Add board files for nRF54LM20A/ns. Update existing nRF54LM20A board files to support this. Upstream PR #: 95743 Signed-off-by: Dag Erik Gjørvad <[email protected]> (cherry picked from commit 7b908b48875438925d61f21c02442ea06fe2c587)
fa9881b
to
16cddf4
Compare
Add board files for nRF54LM20A/ns.
Update existing nRF54LM20A board files to support this.
Upstream PR #: 95743