[nrf fromlist] drivers: i2s: nrfx_i2s: introduce prescaler calculation #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
7869994 to
b5d0068
Compare
masz-nordic
requested review from
anangl,
bjarki-andreasen,
kl-cruz and
masz-nordic
kl-cruz
approved these changes
Sep 30, 2025
anangl
requested changes
Sep 30, 2025
anangl
reviewed
Sep 30, 2025
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
b5d0068 to
b8ab857
Compare
anangl
reviewed
Sep 30, 2025
drivers/i2s/i2s_nrfx.c
Outdated
| config->ratio = ratios[best_r].ratio_enum; | ||
| LOG_INF("I2S MCK frequency: %u, actual PCM rate: %u", | ||
| best_mck, best_mck / ratios[best_r].ratio_val); | ||
| nrfx_i2s_prescalers_calc(src_freq, i2s_cfg->frame_clk_freq, config->sample_width, |
There was a problem hiding this comment.
Shouldn't the return value be handled somehow?
There was a problem hiding this comment.
I added log, similar to how it have been handled before
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
b8ab857 to
c8df1dc
Compare
anangl
reviewed
Sep 30, 2025
drivers/i2s/i2s_nrfx.c
Outdated
| } | ||
| } | ||
| } | ||
| if (!nrfx_i2s_prescalers_calc(src_freq, i2s_cfg->frame_clk_freq, config->sample_width, |
There was a problem hiding this comment.
nrfx_i2s_prescalers_calc returns nrfx_err_t, not bool.
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
c8df1dc to
a24dd1a
Compare
anangl
approved these changes
Sep 30, 2025
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
a24dd1a to
30def77
Compare
magp-nordic
approved these changes
Oct 1, 2025
…nd MCK Ratios nRF53 series SoCs have a dedicated configurable audio PLL and the ability to enable MCK bypass via a register value CONFIG.CLKCONFIG. This can enable higher MCK/LRCK ratios that some I2S peripherals require the host to generate. Allow an application developer to choose if they want to initially look for a bypass ratio and, if found, enable bypass in the NRFX driver. If not, the standard MCK calculation is conducted as normal. Signed-off-by: Sean O'Connor <[email protected]> (cherry picked from commit 8115d9b)
Added usage of new API responsible for calculating I2S prescaler values. Upstream PR #: 96703 Signed-off-by: Michał Stasiak <[email protected]>
mstasiaknordic
force-pushed
the
nrfx_i2s_prescaler_calc
branch
from
30def77 to
78d5af5
Compare
…rf54h20 PPR XIP Add overlay and config file required to run the uart_async_api test on nrf54h20dk/nrf54h20/cpuppr/xip platform. Signed-off-by: Sebastian Głąb <[email protected]> (cherry picked from commit e0a9a16)
masz-nordic
merged commit 3c9c5b7
into
nrfconnect:collab-nrfx-4.0
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added usage of new API responsible for calculating I2S prescaler values.
Upstream PR #: 96703