-
Notifications
You must be signed in to change notification settings - Fork 724
Fixed passkey deprecation #3466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixed passkey deprecation #3466
Conversation
Adds the BT_APP_PASSKEY Kconfig, which allows the application to provide passkeys for pairing using the new `app_passkey()` callback. This is an alternative to BT_FIXED_PASSKEY, which will be deprecated in a later commit. Signed-off-by: Håvard Reierstad <[email protected]> (cherry picked from commit 6c64054) Signed-off-by: alperen sener <[email protected]>
The BT_FIXED_PASSKEY Kconfig option is being deprecated, and is replaced by BT_APP_PASSKEY. The reason for the deprecation is an upcoming errata, ES-24489, which mandates that a new passkey shall be generated for each pairing procedure. Signed-off-by: Håvard Reierstad <[email protected]> (cherry picked from commit 82cfb5a) Signed-off-by: alperen sener <[email protected]>
Updates the bt shell API to use the new Kconfig option BT_APP_PASSKEY instead of BT_FIXED_PASSKEY as this is being deprecated. Signed-off-by: Håvard Reierstad <[email protected]> (cherry picked from commit b6252b5) Signed-off-by: alperen sener <[email protected]>
| * pairing, or BT_PASSKEY_RAND to generate a random passkey. This callback is invoked only | ||
| * for the Passkey Entry method as defined in Core Specification Vol. 3, Part H. Which | ||
| * device in the pairing is showing the passkey depends on the IO capabilities of the | ||
| * device; see Table 2.8 of the Bluetooth Core Specification V6.0, Vol. 3, Part H for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better not to specify version, so we don't need to update it with every spec release. The way core spec is developed guarantees that existing section numbers will not change in future specs.
| * device; see Table 2.8 of the Bluetooth Core Specification V6.0, Vol. 3, Part H for more | |
| * device; see Table 2.8 of the Bluetooth Core Specification, Vol. 3, Part H for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I do it here? I don't know actually since this is upstream commit? any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to fix this in upstream instead of noup here.
Cherry-pick for deprecating fixed passkey.