Repository navigation
drivers: modem: quectel-bg9x: fix ICCID prefix strip length - #4616
Open
bjarki-andreasen wants to merge 1 commit into
Open
bjarki-andreasen wants to merge 1 commit into
bjarki-andreasen wants to merge 1 commit into
Conversation
…ength on_cmd_atcmdinfo_iccid() strips the "+QCCID: " prefix by moving the remaining characters to the start of mdm_iccid. It computed the length of the remainder into out_len but passed the length of the whole response line to memmove(). The copy read past the end of mdm_iccid on every prefixed response, and a response line of 32 characters or more also wrote past it into the following members of struct modem_data. Copy out_len + 1 bytes instead. out_len is bounded by the NUL-terminated contents of mdm_iccid, so the copy stays within the buffer. Signed-off-by: Flavio Ceolin <flavio@hubble.com> (cherry picked from commit 37a6803ed8da0307dfa5438208a6c3e4cfde8cf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick of drivers: modem: quectel-bg9x: fix ICCID prefix strip length