Repository navigation
drivers: charger: reject notifier properties from user mode - #4623
Open
bjarki-andreasen wants to merge 1 commit into
Open
bjarki-andreasen wants to merge 1 commit into
bjarki-andreasen wants to merge 1 commit into
Conversation
… mode union charger_propval carries two function pointers, selected by CHARGER_PROP_STATUS_NOTIFICATION and CHARGER_PROP_ONLINE_NOTIFICATION. z_vrfy_charger_set_prop copied the whole union in without inspecting prop, and drivers store those members and later call them. z_vrfy_charger_get_prop copied the union back out the same way. Reject both properties in both verifiers, including when the callback is NULL: the notifiers are device state, so allowing a clear would let user mode disable a notifier a supervisor thread installed. A BUILD_ASSERT on CHARGER_PROP_COMMON_COUNT forces the list to be revisited when a property is added. Supervisor mode is unaffected. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org> Assisted-by: Claude:claude-opus-5 (cherry picked from commit 5467b7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick of drivers: charger: reject notifier properties from user mode