Error message when suit sequence number larger than uint32 #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasztag
force-pushed
the
NCSDK-32183_detect_to_large_seq_number
branch
from
cdc32a2 to
82ace19
Compare
tomchy
approved these changes
Apr 2, 2025
ahasztag
force-pushed
the
NCSDK-32183_detect_to_large_seq_number
branch
from
82ace19 to
a9c093a
Compare
robertstypa
approved these changes
Apr 4, 2025
suit_generator/suit/manifest.py
Outdated
|
|
||
|
|
||
| class SuitSequenceNumber(SuitUint): | ||
| """Representation of unsigned int type.""" |
Collaborator
There was a problem hiding this comment.
nit: Consider something like: Representation of SUIT sequence number
Ref: NCSDK-32183 Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-32183_detect_to_large_seq_number
branch
from
a9c093a to
02cf2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: NCSDK-32183