Skip to content

fix: remove over-eager debug logging filtering from connectionManager (SOFIE-4336) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jstarpl wants to merge 1 commit into
base: release52
Choose a base branch
from
Open

fix: remove over-eager debug logging filtering from connectionManager (SOFIE-4336) #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/playout-gateway/src/tsrHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,12 @@ export class TSRHandler {
const device = this._coreTsrHandlers[id]?._device
const name = `Device "${device?.deviceName ?? id}" (${device?.instanceId ?? 'instance unknown'})`

if (!e || !('message' in e)) {
return {
message: name + ': ' + 'Unknown error: ' + JSON.stringify(e),
}
}

return {
message: e.message && name + ': ' + e.message,
name: e.name && name + ': ' + e.name,
Expand Down Expand Up @@ -370,7 +376,7 @@ export class TSRHandler {
this.tsr.connectionManager.on('connectionEvent:debug', (id, ...args) => {
const device = this._coreTsrHandlers[id]?._device

if (!device?.debugLogging && !this._coreHandler.logDebug) {
if (!this._coreHandler.logDebug) {
return
}
if (args.length === 0) {
Expand Down
Loading