Skip to content

fix(intellij): read nx version under read action #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxKless wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(intellij): read nx version under read action #3118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/intellij/src/main/kotlin/dev/nx/console/utils/sync_services/NxVersionUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ class NxVersionUtil(private val project: Project, private val cs: CoroutineScope
return if (ApplicationManager.getApplication().isDispatchThread) {
nxVersion
} else {
Comment on lines 49 to 51

@graphite-app graphite-app Bot Apr 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent behavior between dispatch and non-dispatch threads. When nxVersion is null on the dispatch thread, it returns null immediately without trying fallback methods. However, on non-dispatch threads, it attempts fallbacks via tryGetNxVersionFromNodeModules() and tryGetNxVersionFromPackageJson(). This creates unpredictable behavior where the same call returns different results depending on which thread it's called from.

If the dispatch thread case also needs to try fallbacks when nxVersion is null, it should wrap the fallback logic in ApplicationManager.getApplication().runReadAction<NxVersion?> or use invokeLater to avoid blocking the EDT:

return if (ApplicationManager.getApplication().isDispatchThread) {
    nxVersion ?: ApplicationManager.getApplication().runReadAction<NxVersion?> {
        tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
    }
} else {
    nxVersion ?: ApplicationManager.getApplication().runReadAction<NxVersion?> {
        tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
    }
}

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

nxVersion ?: tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
nxVersion
?: ApplicationManager.getApplication().runReadAction<NxVersion?> {
tryGetNxVersionFromNodeModules() ?: tryGetNxVersionFromPackageJson()
}
}
}

Expand Down
Loading