-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(linter): add peerDepsVersionStrategy option to dependency-checks #33417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add peerDepsVersionStrategy option to dependency-checks #33417
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
63a038c to
281e5f7
Compare
281e5f7 to
a0d061e
Compare
|
Hi @meeroslav , could you please let me know when you might be able to take a look at this change? |
|
Any update on this? |
|
Hey @hosembafer, thanks for the PR. It makes sense to write |
… rule Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing. When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version. Defaults to 'installed' to maintain backward compatibility.
…rategy is workspace
2d78843 to
c8b8eb8
Compare
|
View your CI Pipeline Execution ↗ for commit e7a0450
☁️ Nx Cloud last updated this comment at |
Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing. When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version. Defaults to 'installed' to maintain backward compatibility.
Current Behavior
A concrete peer dependency version is being fixed.
Expected Behavior
User can choose between
installedandworkspaceversion strategies.