Skip to content

Conversation

@hosembafer
Copy link
Contributor

Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing. When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version. Defaults to 'installed' to maintain backward compatibility.

Current Behavior

A concrete peer dependency version is being fixed.

Expected Behavior

User can choose between installed and workspace version strategies.

@hosembafer hosembafer requested review from a team as code owners November 8, 2025 18:04
@hosembafer hosembafer requested a review from meeroslav November 8, 2025 18:04
@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit e7a0450
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6952dc390f831d00080777f6
😎 Deploy Preview https://deploy-preview-33417--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link

vercel bot commented Nov 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Dec 29, 2025 7:59pm

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@hosembafer
Copy link
Contributor Author

Hi @meeroslav , could you please let me know when you might be able to take a look at this change?

@ashotkosakyan
Copy link

Any update on this?

@jaysoo
Copy link
Member

jaysoo commented Dec 29, 2025

Hey @hosembafer, thanks for the PR. It makes sense to write workspace:* if something is missing, but for checking we should also make sure workspace:~ and workspace:^ are supported. We should also clarify that this is only for PNPM.

hosembafer and others added 4 commits December 29, 2025 14:23
… rule

Adds a new peerDepsVersionStrategy option that allows configuring how peer dependencies versions are set when auto-fixing.
When set to 'workspace', peer dependencies will use 'workspace:*' instead of the installed or root package version.
Defaults to 'installed' to maintain backward compatibility.
@jaysoo jaysoo force-pushed the feature/peer-deps-version-strategy branch from 2d78843 to c8b8eb8 Compare December 29, 2025 19:29
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 29, 2025

View your CI Pipeline Execution ↗ for commit e7a0450

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 22m 27s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 40s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-29 20:21:42 UTC

@jaysoo jaysoo merged commit 97fde57 into nrwl:master Dec 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants