-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(core): only run nx console background check if daemon is active #33917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit e965f6a
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
Our failing Maven e2e tests are encountering an external service issue where Spring Initializr (start.spring.io) now rejects Spring Boot 3.4.0 and requires >=3.5.0. This is unrelated to the daemon client changes in this PR and represents an environment_state failure caused by the external API updating its compatibility requirements.
No code changes were suggested for this issue.
🔂 A CI rerun has been triggered by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
…Self-Healing CI Rerun]

Current Behavior
running commands while the nx daemon is disabled will check the nx console status - which sends a message to the daemon and thus enables it.
This can cause weird race conditions.
Expected Behavior
As it's a non-critical check, we should only send messages to the daemon if it's running.
Related Issue(s)
Fixes #