feat(rspack): add typeCheckOptions, runtimeDependencies, and cache options #33931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for the mergeExternals option in NxAppWebpackPlugin.
…config.ts Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
# Conflicts: # docs/shared/packages/webpack/webpack-plugins.md # packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts # packages/webpack/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
davidantoon
changed the title
Coly010
changed the title
Contributor
|
@davidantoon Can you update the deprecation method to mention: 1. what to use instead, 2. that the deprecated property will be removed in Nx 24 |
Contributor
|
View your CI Pipeline Execution ↗ for commit 58b8dab
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
I've updated all deprecation messages for skipTypeChecking (and related typeCheck option) across the following files: Documentation
Webpack package
Rspack package
All deprecation messages now include:
|
Coly010
reviewed
Dec 22, 2025
packages/rspack/src/plugins/utils/plugins/generate-package-json-plugin.ts
Outdated
Show resolved
Hide resolved
Coly010
requested changes
Dec 22, 2025
Contributor
Coly010
left a comment
Coly010
left a comment
There was a problem hiding this comment.
Some minor changes to parsing the package.json for the deps, in the chance that they are not being resolved from the root node_modules folder. (nested node_modules etc)
packages/rspack/src/plugins/utils/plugins/generate-package-json-plugin.ts
Show resolved
Hide resolved
based on pr code review comment, updated the rspack and webpack plugins json read to use readJsonFile from nx/devkit instead of standard fs, also using resolve instead of static readfile to support node_modules in project folder
Contributor
Author
@Coly010 DONE |
Coly010
approved these changes
Dec 23, 2025
Contributor
Author
|
@leosvelperez can you please review and approve this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
skipTypeCheckingoption is a simple boolean that only allows enabling/disabling type checkingruntimeDependenciesoption that webpack hascacheconfiguration is hardcoded and cannot be overridden by usersExpected Behavior
typeCheckOptionsoption allows configuring type checking with{ async: true }to run type checking in a separate process without blocking the buildskipTypeCheckingoption is maintained for backward compatibilityruntimeDependenciesoption for adding runtime dependencies to generatedpackage.json(useful for Docker installs)cacheoption allows users to override webpack/rspack caching behavior while maintaining backward-compatible defaultsRelated Issue(s)
N/A - Standalone feature
Changes Made
typeCheckOptions (webpack & rspack)
TypeCheckOptionsinterface withasyncpropertytypeCheckOptionsoption to plugin options interfacesapply-base-config.tsto normalizetypeCheckOptionsfrom deprecatedskipTypeCheckingfor backward compatibilityschema.jsonandschema.d.tsruntimeDependencies (webpack & rspack)
runtimeDependenciesoption toNxAppRspackPluginOptionsGeneratePackageJsonPluginto resolve and include runtime dependenciesschema.jsonandschema.d.tscache (webpack & rspack)
cacheoption to plugin options interfacesapply-base-config.tsto check'cache' in optionsbefore applying defaultscache: undefinedto force cache to be disabled{ type: 'memory' }for Node targets in watch modetruefor Node targets in watch mode,truein dependent configFiles Changed
Webpack:
packages/webpack/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.tspackages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.tspackages/webpack/src/executors/webpack/schema.jsonpackages/webpack/src/executors/webpack/schema.d.tspackages/webpack/src/plugins/generate-package-json-plugin.tsRspack:
packages/rspack/src/plugins/utils/models.tspackages/rspack/src/plugins/utils/apply-base-config.tspackages/rspack/src/plugins/utils/plugins/generate-package-json-plugin.tspackages/rspack/src/executors/rspack/schema.jsonpackages/rspack/src/executors/rspack/schema.d.tsDocumentation:
astro-docs/.../webpack/Guides/webpack-plugins.mdocpackages/webpack/docs/webpack-build-executor-examples.md