-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(maven): bump spring version and re-enable maven e2e #33934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit ebdc3b3
☁️ Nx Cloud last updated this comment at |
9ece218 to
2595705
Compare
2595705 to
a15e35d
Compare
03ac38a to
ca728ac
Compare
f169ab6 to
88806e3
Compare
88806e3 to
f536d87
Compare
77f8b16 to
159d75f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud is proposing a fix for your failed CI:
We've identified that the flattenMode=oss configuration requires the parent POM to be resolvable from the local Maven repository. By changing maven.install.skip from true to false for nx-maven-parent, we ensure it's installed locally during the build process, allowing e2e tests to properly resolve the nx-maven-plugin and its parent POM dependency. This maintains the PR's intent to use OSS-standard flattening while fixing the Maven artifact resolution failure.
We are verifying this fix by re-running e2e-maven:e2e-ci--src/maven-batch.test.ts.
diff --git a/packages/maven/pom.xml b/packages/maven/pom.xml
index b3879ca94c..86a4649c12 100644
--- a/packages/maven/pom.xml
+++ b/packages/maven/pom.xml
@@ -24,7 +24,7 @@
<properties>
<!-- Skip deployment for this parent POM -->
- <maven.install.skip>true</maven.install.skip>
+ <maven.install.skip>false</maven.install.skip>
<maven.deploy.skip>true</maven.deploy.skip>
<maven.gpg.skip>true</maven.gpg.skip>
</properties>
Or Apply changes locally with:
npx nx-cloud apply-locally lanN-CxlG
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
6d106d6 to
ebdc3b3
Compare

Current Behavior
Expected Behavior
Related Issue(s)
Fixes #