fix(core): provide actionable feedback when running migrations and pre-install fails with npm peer dep errors #33961
+113
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-install fails with npm peer dep errors
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 20757e6
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running
nx migrate --run-migrationsin a workspace withnpmas the package manager, sometimes the automatic package installation performed by the command can fail due to peer dependency constraint violations. In such cases, no actionable feedback is provided to the user to help resolve the issue.Expected Behavior
When running
nx migrate --run-migrationsin a workspace withnpmas the package manager, and the automatic package installation performed by the command fails, Nx should provide actionable feedback to resolve the issue and to re-run the command while skipping the package installation.Related Issue(s)
Fixes #33942