Skip to content

fix(core): allow nx build scripts in generated pnpm-workspace.yaml #35564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cogwirrel wants to merge 2 commits into
base: master
Choose a base branch
from
+42 −7
Open

fix(core): allow nx build scripts in generated pnpm-workspace.yaml #35564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7cbfa8
fix(core): allow nx build scripts in generated pnpm-workspace.yaml
cogwirrel May 5, 2026
585b4a0
fix(core): version-gate pnpm build allowlist in generated pnpm-worksp…
cogwirrel May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/workspace/src/generators/new/generate-workspace-files.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ describe('@nx/workspace:generateWorkspaceFiles', () => {
- "packages/*"

autoInstallPeers: true
allowBuilds:
nx: true
onlyBuiltDependencies:
- nx
"
`);
expect(tree.exists('proj/.npmrc')).toBeFalsy();
Expand Down
8 changes: 6 additions & 2 deletions packages/workspace/src/generators/new/generate-workspace-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,12 +335,16 @@ async function createReadme(
});
}

// ensure that pnpm install add all the missing peer deps

// pnpm 11 requires allowBuilds for packages with postinstall scripts;
// onlyBuiltDependencies is the pnpm 10 equivalent (unknown keys are ignored).
function addPnpmSettings(tree: Tree, options: NormalizedSchema) {
tree.write(
join(options.directory, 'pnpm-workspace.yaml'),
`autoInstallPeers: true
allowBuilds:
nx: true
onlyBuiltDependencies:
- nx
`
);
}
Expand Down
Loading