Skip to content

feat(angular)!: remove deprecated ngrx generator#35567

Open
leosvelperez wants to merge 2 commits intomasterfrom
angular/remove-ngrx-generator
Open

feat(angular)!: remove deprecated ngrx generator#35567
leosvelperez wants to merge 2 commits intomasterfrom
angular/remove-ngrx-generator

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Current Behavior

The @nx/angular:ngrx generator is exposed and functional, but has been deprecated since Nx v18 in favor of @nx/angular:ngrx-root-store (root state) and @nx/angular:ngrx-feature-store (feature state).

Expected Behavior

The @nx/angular:ngrx generator is removed. Users invoke @nx/angular:ngrx-root-store for root state and @nx/angular:ngrx-feature-store for feature state instead.

A migration splits any @nx/angular:ngrx generator defaults set in nx.json across the two replacement generator keys, renames the deprecated module option to parent, and drops the obsolete root toggle (intent is now expressed by which generator is invoked). The migration handles both the flat ("@nx/angular:ngrx") and nested ("@nx/angular": { "ngrx": ... }) defaults shapes.

BREAKING CHANGE: The @nx/angular:ngrx generator has been removed. Use @nx/angular:ngrx-root-store for root state and @nx/angular:ngrx-feature-store for feature state instead.

@leosvelperez leosvelperez self-assigned this May 5, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit cbe1df1
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69fafc7b037c9700083150ea
😎 Deploy Preview https://deploy-preview-35567--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit cbe1df1
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69fafc7bed71b30008ff15b9
😎 Deploy Preview https://deploy-preview-35567--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 5, 2026

View your CI Pipeline Execution ↗ for commit 6485fb3

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 23m 44s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 17s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-06 08:59:12 UTC

@leosvelperez leosvelperez marked this pull request as ready for review May 5, 2026 10:25
@leosvelperez leosvelperez requested a review from a team as a code owner May 5, 2026 10:25
@leosvelperez leosvelperez requested a review from JamesHenry May 5, 2026 10:25
Remove the `@nx/angular:ngrx` generator. Use `@nx/angular:ngrx-root-store`
for root state and `@nx/angular:ngrx-feature-store` for feature state instead.

A migration splits any `@nx/angular:ngrx` defaults set in `nx.json` across
the two replacement generators.
@leosvelperez leosvelperez force-pushed the angular/remove-ngrx-generator branch from 5d1435d to 6485fb3 Compare May 6, 2026 07:40
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@leosvelperez leosvelperez requested a review from FrozenPandaz May 6, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants