Skip to content

feat(misc): drop Node 20 support and bump @types/node#35591

Open
jaysoo wants to merge 2 commits intomasterfrom
NXC-4159
Open

feat(misc): drop Node 20 support and bump @types/node#35591
jaysoo wants to merge 2 commits intomasterfrom
NXC-4159

Conversation

@jaysoo
Copy link
Copy Markdown
Member

@jaysoo jaysoo commented May 6, 2026

Current Behavior

CI matrices test Node 20. @types/node pinned to v20 in the repo catalog and generator constants.

Expected Behavior

Generator typesNodeVersion bumps to ^22.0.0.

Node 20 dropped from e2e + nightly matrices and ESLint docs (EOL Apr 2026). Repo catalog bumps to ^24.11.0 to match
mise.toml. Nightly nodeTLS renamed to lowestNodeLTS and bumped to 22.

Related Issue(s)

NXC-4159

@jaysoo jaysoo requested a review from a team as a code owner May 6, 2026 14:43
@jaysoo jaysoo requested a review from lourw May 6, 2026 14:43
@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 8a49d36
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69fb9e679202af000852dfa3
😎 Deploy Preview https://deploy-preview-35591--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 8a49d36
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69fb9e67eb2b120008eba187
😎 Deploy Preview https://deploy-preview-35591--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 6, 2026

View your CI Pipeline Execution ↗ for commit 8a49d36

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 19m 19s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 14s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx affected -t e2e-macos-local --parallel=1 --b... ✅ Succeeded 2m 28s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-06 22:05:11 UTC

jaysoo added 2 commits May 6, 2026 16:02
## Current Behavior

CI matrices test Node 20. Generators install `@types/node@20.19.9`. Repo dev catalog pins `@types/node@^20.19.10`. Nightly matrix references `nodeTLS: 20` for non-core plugin coverage.

## Expected Behavior

Node 20 dropped from e2e + nightly matrices and ESLint docs (EOL Apr 2026). Generator `typesNodeVersion` bumps to `^22.0.0` (new supported floor). Repo catalog bumps to `^24.11.0` to match `mise.toml` runtime. Nightly `nodeTLS: 20` renamed to `lowestNodeLTS: 22` (typo fix + bump). Non-core plugins still run on a single LTS only.

## Related Issue(s)

NXC-4159
## Current Behavior

Nightly matrix runs core e2e on Node 22 + 24.

## Expected Behavior

Adds Node 26.0.0 (just released) to the nightly matrix on both OSes for early validation. Non-core plugins still pin to `lowestNodeLTS: 22`. Total matrix size 152 / 256.

## Related Issue(s)

NXC-4159
Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud has identified a possible root cause for your failed CI:

We investigated the two CI failures and neither is caused by this PR's changes. The e2e-maven failure is an npm ECOMPROMISED infrastructure error unrelated to the Node 20 drop or @types/node bump, and the e2e-nx cache timeout is a known flaky test (~15% flakiness rate) with no connection to the diff. Both failures are safe to re-trigger.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants