Skip to content

chore(repo): bump node to 26 and update mise tool versions #35604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrozenPandaz wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore(repo): bump node to 26 and update mise tool versions #35604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22473da
chore(repo): bump node to 26 and update mise tool versions
claude May 6, 2026
81907df
chore(repo): keep node 24 in matrix lists alongside 26
claude May 6, 2026
dbdc5f1
chore(repo): only append node 26 to multi-version matrix lists
claude May 6, 2026
051b4e8
chore(gradle): bump gradle wrapper from 8.14.3 to 9.5.0 for java 26 s…
claude May 6, 2026
24155a2
chore(gradle): migrate shadow plugin to com.gradleup.shadow 9.4.1
claude May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/banner-monitor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
if: steps.compare.outputs.changed == 'true'
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '24'
node-version: '26'

- name: Trigger Netlify deploys
if: steps.compare.outputs.changed == 'true'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/generate-embeddings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['24']
node-version: ['26']

steps:
- name: Checkout
Expand All @@ -19,7 +19,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '24'
node-version: '26'
package-manager-cache: false

- name: Install pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-notifier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Use Node.js ${{ matrix.node_version }}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: '24'
node-version: '26'
cache: 'pnpm'

- name: Cache node_modules
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly/process-matrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ const matrixData: MatrixData = {
os_name: 'Linux',
os_timeout: 60,
package_managers: ['npm', 'pnpm', 'yarn'],
node_versions: ['20.19.0', '22.13.0', '24.0.0'],
node_versions: ['20.19.0', '22.13.0', '24.0.0', '26.0.0'],
Copy link
Copy Markdown
Contributor

@graphite-app graphite-app Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Node version update strategy. This line adds '26.0.0' to the array (keeping '24.0.0'), while line 84 replaces '24.0.0' with '26.0.0' for MacOS. This will expand the Linux test matrix from 3 to 4 Node versions (running 12 combinations instead of 9 per package manager), significantly increasing CI time and costs.

Based on the PR description using "→" notation and the MacOS replacement pattern, this should likely be:

node_versions: ['20.19.0', '22.13.0', '26.0.0'],

If testing against Node 24 is still required, then line 84 should also keep '24.0.0' for consistency.

Suggested change
node_versions: ['20.19.0', '22.13.0', '24.0.0', '26.0.0'],
node_versions: ['20.19.0', '22.13.0', '26.0.0'],

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo']
},
// Docker is not supported on ARM-based macOS runners (no nested virtualization)
// See: https://github.com/docker/setup-docker-action and https://github.com/douglascamata/setup-docker-macos-action
// We may want to look into adding intel only for this docker case, at least until vm-in-vm works on latest macos
{ os: 'macos-latest', os_name: 'MacOS', os_timeout: 90, package_managers: ['npm'], node_versions: ['24.0.0'], excluded: ['e2e-docker'] }
{ os: 'macos-latest', os_name: 'MacOS', os_timeout: 90, package_managers: ['npm'], node_versions: ['26.0.0'], excluded: ['e2e-docker'] }
// TODO (Jack): Fix Windows support as gradle fails when running nx build https://staging.nx.app/runs/LgD4vxGn8w?utm_source=pull-request&utm_medium=comment
// { os: 'windows-latest', os_name: 'WinOS', os_timeout: 180, package_managers: ['npm'], node_versions: ['24.0.0'], excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo'] }
// { os: 'windows-latest', os_name: 'WinOS', os_timeout: 180, package_managers: ['npm'], node_versions: ['26.0.0'], excluded: ['e2e-detox', 'e2e-react-native', 'e2e-expo'] }
]
};

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-title-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
with:
node-version: 24
node-version: 26
package-manager-cache: false

- name: Validate PR title
Expand Down
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ junit = "5.10.1"
kotlinx-coroutines = "1.7.3"
slf4j = "1.7.10"
gradle-tooling-api = "8.13"
shadow = "8.1.1"
shadow = "9.4.1"
ktfmt = "0.25.0"
nx-project-graph = "0.1.20"
gradle-plugin-publish = "1.2.1"
Expand All @@ -33,7 +33,7 @@ opentelemetry-exporter-otlp = { module = "io.opentelemetry:opentelemetry-exporte

[plugins]
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
shadow = { id = "com.github.johnrengelman.shadow", version.ref = "shadow" }
shadow = { id = "com.gradleup.shadow", version.ref = "shadow" }
ktfmt = { id = "com.ncorti.ktfmt.gradle", version.ref = "ktfmt" }
nx-project-graph = { id = "dev.nx.gradle.project-graph", version.ref = "nx-project-graph" }
gradle-plugin-publish = { id = "com.gradle.plugin-publish", version.ref = "gradle-plugin-publish" }
Binary file modified gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
4 changes: 2 additions & 2 deletions gradlew
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gradlew.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[tools]
bun = "1.3"
java = "24"
node = "{{ env['NODE_VERSION'] | default(value='24.11.0') }}"
maven = "3.9.11"
rust = "1.90.0"
vale = "3.13.1"
java = "26"
node = "{{ env['NODE_VERSION'] | default(value='26.0.0') }}"
maven = "3.9.15"
rust = "1.95.0"
vale = "3.14.1"

# Ensure that the packageManager field gets used to resolve the correct version of pnpm
# https://github.com/jdx/mise/discussions/3549#discussioncomment-11918572
Expand Down
Loading