Skip to content

Update datasource.html.markdown#155

Open
ionigman wants to merge 2 commits into
ns1-terraform:masterfrom
ionigman:patch-2
Open

Update datasource.html.markdown#155
ionigman wants to merge 2 commits into
ns1-terraform:masterfrom
ionigman:patch-2

Conversation

@ionigman

Copy link
Copy Markdown
Contributor

Update to documentation to reflect proper usage for monitoring datasources.

sourcetype = "nsone_v1"
}
```
OR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add this to the example above with a unique resource name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be a seperate code block, any reason we can't remove the OR and combine both resources into a single code block, as in other examples?

sourcetype = "nsone_v1"
}
```
OR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still appears to be a seperate code block, any reason we can't remove the OR and combine both resources into a single code block, as in other examples?

@ThiagoYU

ThiagoYU commented Oct 1, 2021

Copy link
Copy Markdown
Contributor

Hi @ionigman, any updates on this? Otherwise, I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants