Disable mouse wheel interaction for input widgets in Preferences

src/global/SignalBlocker.cpp

@@ -7,8 +7,18 @@
 
 #include <cassert>
 
+#include <QEvent>
 #include <QWidget>
 
+bool mmqt::applyWheelEventFilter(QObject *const /*obj*/, QEvent *const event)
+{
+    if (event->type() == QEvent::Wheel) {
+        event->ignore();
+        return true;
+    }
+    return false;
+}
+
 SignalBlocker::SignalBlocker(QObject &in)
     : obj{in}
     , wasBlocked{obj.signalsBlocked()}

src/global/SignalBlocker.h

@@ -5,6 +5,7 @@
 #include "RuleOf5.h"
 #include "utils.h"
 
+#include <QEvent>
 #include <QObject>
 #include <QVector>
 
@@ -23,3 +24,7 @@ class NODISCARD SignalBlocker final
     ~SignalBlocker();
     DELETE_CTORS_AND_ASSIGN_OPS(SignalBlocker);
 };
+
+namespace mmqt {
+NODISCARD extern bool applyWheelEventFilter(QObject *obj, QEvent *event);
+}

src/preferences/configdialog.cpp

@@ -7,6 +7,7 @@
 #include "configdialog.h"
 
 #include "../configuration/configuration.h"
+#include "../global/SignalBlocker.h"
 #include "audiopage.h"
 #include "autologpage.h"
 #include "clientpage.h"
@@ -18,10 +19,28 @@
 #include "pathmachinepage.h"
 #include "ui_configdialog.h"
 
+#include <QAbstractSlider>
+#include <QAbstractSpinBox>
+#include <QComboBox>
 #include <QIcon>
 #include <QListWidget>
 #include <QtWidgets>
 
+namespace {
+class WheelEventFilter final : public QObject
+{
+public:
+    explicit WheelEventFilter(QObject *const parent)
+        : QObject(parent)
+    {}
+
+    bool eventFilter(QObject *const obj, QEvent *const event) override
+    {
+        return mmqt::applyWheelEventFilter(obj, event);
+    }
+};
+} // namespace
+
 ConfigDialog::ConfigDialog(QWidget *const parent)
     : QDialog(parent)
     , ui(new Ui::ConfigDialog)
@@ -86,6 +105,17 @@ ConfigDialog::ConfigDialog(QWidget *const parent)
             &GraphicsPage::sig_graphicsSettingsChanged,
             this,
             &ConfigDialog::sig_graphicsSettingsChanged);
+
+    auto *const filter = new WheelEventFilter(this);
+    for (auto *const comboBox : findChildren<QComboBox *>()) {
+        comboBox->installEventFilter(filter);
+    }
+    for (auto *const slider : findChildren<QAbstractSlider *>()) {
+        slider->installEventFilter(filter);
+    }
+    for (auto *const spinBox : findChildren<QAbstractSpinBox *>()) {
+        spinBox->installEventFilter(filter);
+    }
 }
 
 ConfigDialog::~ConfigDialog()

tests/TestGlobal.cpp

@@ -14,6 +14,7 @@
 #include "../src/global/LineUtils.h"
 #include "../src/global/RAII.h"
 #include "../src/global/Signal2.h"
+#include "../src/global/SignalBlocker.h"
 #include "../src/global/StringView.h"
 #include "../src/global/TaggedString.h"
 #include "../src/global/TextUtils.h"
@@ -647,4 +648,27 @@ void TestGlobal::weakHandleTest()
     test::testWeakHandle();
 }
 
+void TestGlobal::wheelEventFilterTest()
+{
+    QObject obj;
+    QWheelEvent wheelEvent(QPointF(0, 0),
+                           QPointF(0, 0),
+                           QPoint(0, 0),
+                           QPoint(0, 120),
+                           Qt::NoButton,
+                           Qt::NoModifier,
+                           Qt::ScrollBegin,
+                           false);
+
+    wheelEvent.setAccepted(false);
+    QVERIFY(!wheelEvent.isAccepted());
+    bool handled = mmqt::applyWheelEventFilter(&obj, &wheelEvent);
+    QVERIFY(handled);
+    QVERIFY(!wheelEvent.isAccepted()); // should be ignored
+
+    QEvent otherEvent(QEvent::MouseButtonPress);
+    handled = mmqt::applyWheelEventFilter(&obj, &otherEvent);
+    QVERIFY(!handled);
+}
+
 QTEST_MAIN(TestGlobal)

tests/TestGlobal.h

@@ -40,4 +40,5 @@ private Q_SLOTS:
     static void toNumberTest();
     static void unquoteTest();
     static void weakHandleTest();
+    static void wheelEventFilterTest();
 };