Fix crash and performance issues in _dirs command

src/group/groupwidget.cpp

@@ -17,6 +17,7 @@
 #include <algorithm>
 #include <cmath>
 #include <map>
+#include <unordered_set>
 #include <vector>
 
 #include <QAction>

src/map/roomid.cpp

@@ -7,6 +7,8 @@
 
 #include <ostream>
 
+#include <QDebug>
+
 std::ostream &operator<<(std::ostream &os, const RoomId id)
 {
     return os << "RoomId(" << id.value() << ")";
@@ -38,3 +40,20 @@ AnsiOstream &operator<<(AnsiOstream &os, const ServerRoomId id)
 {
     return os << "ServerRoomId(" << id.value() << ")";
 }
+
+///
+
+QDebug operator<<(QDebug debug, const RoomId id)
+{
+    return debug << "RoomId(" << id.value() << ")";
+}
+
+QDebug operator<<(QDebug debug, const ExternalRoomId id)
+{
+    return debug << "ExternalRoomId(" << id.value() << ")";
+}
+
+QDebug operator<<(QDebug debug, const ServerRoomId id)
+{
+    return debug << "ServerRoomId(" << id.value() << ")";
+}

src/map/roomid.h

@@ -11,6 +11,8 @@
 #include <cstdint>
 #include <ostream>
 
+#include <QDebug>
+
 class AnsiOstream;
 
 namespace tags {
@@ -31,6 +33,7 @@ struct NODISCARD RoomId final : public TaggedInt<RoomId, tags::RoomIdTag, uint32
     NODISCARD constexpr uint32_t asUint32() const { return value(); }
     friend std::ostream &operator<<(std::ostream &os, RoomId id);
     friend AnsiOstream &operator<<(AnsiOstream &os, RoomId id);
+    friend QDebug operator<<(QDebug debug, RoomId id);
 };
 
 struct NODISCARD ExternalRoomId final
@@ -43,6 +46,7 @@ struct NODISCARD ExternalRoomId final
     NODISCARD constexpr uint32_t asUint32() const { return value(); }
     friend std::ostream &operator<<(std::ostream &os, ExternalRoomId id);
     friend AnsiOstream &operator<<(AnsiOstream &os, ExternalRoomId id);
+    friend QDebug operator<<(QDebug debug, ExternalRoomId id);
 };
 
 struct NODISCARD ServerRoomId final
@@ -55,6 +59,7 @@ struct NODISCARD ServerRoomId final
     NODISCARD constexpr uint32_t asUint32() const { return value(); }
     friend std::ostream &operator<<(std::ostream &os, ServerRoomId id);
     friend AnsiOstream &operator<<(AnsiOstream &os, ServerRoomId id);
+    friend QDebug operator<<(QDebug debug, ServerRoomId id);
 };
 
 static_assert(sizeof(RoomId) == sizeof(uint32_t));

src/mapdata/GenericFind.cpp

@@ -3,17 +3,37 @@
 
 #include "GenericFind.h"
 
+#include "../global/Timer.h"
+#include "../global/thread_utils.h"
 #include "../map/Map.h"
 #include "roomfilter.h"
 
 RoomIdSet genericFind(const Map &map, const RoomFilter &f)
 {
-    RoomIdSet result;
-    map.getRooms().for_each([&result, &map, &f](const RoomId id) {
-        const auto &room = map.getRawRoom(id);
-        if (f.filter(room)) {
-            result.insert(id);
-        }
-    });
-    return result;
+    DECL_TIMER(t, "genericFind (parallel)");
+
+    struct TlData final
+    {
+        RoomIdSet result;
+    };
+
+    ProgressCounter pc;
+    TlData tl_data;
+
+    thread_utils::parallel_for_each_tl<TlData>(
+        map.getRooms(),
+        pc,
+        [&map, &f](TlData &tl, const RoomId id) {
+            const auto &room = map.getRawRoom(id);
+            if (f.filter(room)) {
+                tl.result.insert(id);
+            }
+        },
+        [&tl_data](auto &tls) {
+            for (auto &tl : tls) {
+                tl_data.result.insertAll(tl.result);
+            }
+        });
+
+    return tl_data.result;
 }