Skip to content

Fix WASM build: undeclared OpenGL constants - #240

Merged
nschimme merged 1 commit into
masterfrom
fix-wasm-build-gl-constants-9197963362326099983
Jul 4, 2026
Merged

Fix WASM build: undeclared OpenGL constants#240
nschimme merged 1 commit into
masterfrom
fix-wasm-build-gl-constants-9197963362326099983

Conversation

@nschimme

@nschimme nschimme commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Guarded desktop-only OpenGL constants in src/display/mapcanvas_gl.cpp with #ifndef Q_OS_WASM to fix compilation errors in the WebAssembly build. Verified that the project still compiles and passes tests on the native target.


PR created automatically by Jules for task 9197963362326099983 started by @nschimme

Summary by Sourcery

Bug Fixes:

  • Prevent use of desktop-only OpenGL context profile and flags constants when compiling for WebAssembly.

The WASM build was failing because it was trying to use desktop-only
OpenGL constants like `GL_CONTEXT_PROFILE_MASK` and `GL_CONTEXT_FLAGS`,
which are not available in OpenGL ES / WebGL 2.0.

This commit wraps the diagnostic logging code using these constants
in `#ifndef Q_OS_WASM` to ensure the project compiles for WebAssembly.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-ai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a WASM-specific guard around OpenGL context profile and flags logging so the WebAssembly build does not reference desktop-only OpenGL constants, while preserving behavior on native targets.

Sequence diagram for MapCanvas::reportGLVersion with WASM guard

sequenceDiagram
    participant MapCanvas
    participant gl as QOpenGLFunctions
    participant Logger

    MapCanvas->>gl: glGetString(GL_VERSION)
    MapCanvas->>Logger: logString("OpenGL Version", GL_VERSION)
    MapCanvas->>Logger: logString("OpenGL Vendor", GL_VENDOR)
    MapCanvas->>Logger: logString("OpenGL GLSL", GL_SHADING_LANGUAGE_VERSION)

    alt [not Q_OS_WASM]
        MapCanvas->>gl: glGetInteger(GL_CONTEXT_PROFILE_MASK)
        MapCanvas->>gl: glGetInteger(GL_CONTEXT_FLAGS)
        MapCanvas->>Logger: logVector("OpenGL context profile", v, flags)
        MapCanvas->>Logger: logVector("OpenGL context flags", v, flags)
    else [Q_OS_WASM]
        Note over MapCanvas,Logger: Context profile and flags logging skipped on WASM
    end
Loading

File-Level Changes

Change Details Files
Guard desktop-only OpenGL context inspection and logging behind a Q_OS_WASM exclude so WebAssembly builds avoid undeclared OpenGL constants.
  • Wrap the block that queries GL_CONTEXT_PROFILE_MASK and context flag bits in a preprocessor guard excluding Q_OS_WASM builds.
  • Keep existing OpenGL version/vendor/GLSL logging logic outside the guard so it still runs on all platforms.
  • Ensure WASM builds skip problematic constants while native builds preserve the existing diagnostic output.
src/display/mapcanvas_gl.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief comment near the #ifndef Q_OS_WASM guard explaining why these OpenGL profile/flag queries are desktop-only so future platform-specific changes are easier to reason about.
  • If possible, prefer checking for the presence of the relevant OpenGL extensions/capabilities instead of a platform macro (Q_OS_WASM), so this code behaves correctly on other constrained OpenGL targets that might also lack these constants.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief comment near the `#ifndef Q_OS_WASM` guard explaining why these OpenGL profile/flag queries are desktop-only so future platform-specific changes are easier to reason about.
- If possible, prefer checking for the presence of the relevant OpenGL extensions/capabilities instead of a platform macro (`Q_OS_WASM`), so this code behaves correctly on other constrained OpenGL targets that might also lack these constants.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.54%. Comparing base (19f7276) to head (abed0d4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #240   +/-   ##
=======================================
  Coverage   25.54%   25.54%           
=======================================
  Files         522      522           
  Lines       43450    43450           
  Branches     4718     4718           
=======================================
  Hits        11100    11100           
  Misses      32350    32350           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nschimme
nschimme merged commit abed0d4 into master Jul 4, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant