consensus: log rejected hashes on CV#4206
Open
AnnaShaleva wants to merge 1 commit into
Open
Conversation
Member
Author
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4206 +/- ##
==========================================
- Coverage 83.50% 83.48% -0.03%
==========================================
Files 359 359
Lines 43881 43899 +18
==========================================
+ Hits 36644 36650 +6
- Misses 5438 5441 +3
- Partials 1799 1808 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Close #4148. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Member
Author
|
@roman-khimov, ready for review. |
roman-khimov
approved these changes
Mar 31, 2026
| func (c *changeView) DecodeBinary(r *io.BinReader) { | ||
| c.timestamp = r.ReadU64LE() | ||
| c.reason = dbft.ChangeViewReason(r.ReadB()) | ||
| if c.reason == dbft.CVTxInvalid || c.reason == dbft.CVTxRejectedByPolicy { |
Member
There was a problem hiding this comment.
Since this is an incompatible change the PR will be blocked for some time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #4148.