Stabilize RPC subscription tests by fixing shutdown/httptest cleanup order#4275
Merged
AnnaShaleva merged 2 commits intoMay 22, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix TestFilteredSubscriptions timeout on Windows
Stabilize RPC subscription tests by fixing shutdown/httptest cleanup order
May 21, 2026
AnnaShaleva
approved these changes
May 22, 2026
Member
AnnaShaleva
left a comment
There was a problem hiding this comment.
Valid one, let's give it a try.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4275 +/- ##
==========================================
- Coverage 83.50% 83.49% -0.01%
==========================================
Files 359 359
Lines 44168 44168
==========================================
- Hits 36883 36879 -4
- Misses 5467 5470 +3
- Partials 1818 1819 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestFilteredSubscriptionscould intermittently hang/timeout on Windows due to websocket lifecycle timing during test teardown. The issue was in test infrastructure cleanup ordering, not subscription filter logic.Root cause addressed: teardown ordering for WS-backed RPC tests
wrapUnitTestChaincleanup registration so RPC shutdown runs beforehttptest.Serverclose duringt.Cleanupexecution (LIFO).Change scope
pkg/services/rpcsrv/server_helper_test.goCode change (illustrative)