Open
Conversation
Switched to Java7 source and target. Updated Maven POM file to refine dependencies scope. Added javadocs generation. Moved test files to src/test/java. Removed all binary files from version control. Removed all project files from version control.
Member
|
@virtuald hey, I've taken over maintenance of this repo - is this ready to go in? |
Author
|
I know we've been using this for awhile without any problems, so yes. |
Member
|
Cool, thanks - want to touch base with @danielhfrank before I move forward with merging things, I know he's been maintaining some changes too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a missing dependency in #9, so mvn test failed.